feat: add support for dataclasses._MISSING_TYPE#1137
Open
majiayu000 wants to merge 1 commit intoomry:masterfrom
Open
feat: add support for dataclasses._MISSING_TYPE#1137majiayu000 wants to merge 1 commit intoomry:masterfrom
majiayu000 wants to merge 1 commit intoomry:masterfrom
Conversation
Owner
|
It doesn't make sense to me to treat dataclass.MISSING_TYPE as an empty dictionary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I am using fairseq with Python 3.11, finding that there are some compatibility issues here.
If I want to use newer version, I have to change some code.
The error code as above
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I made a test file to reproduce this error.
Fixes
Fixes #1136
Related PRs
Not found