fix: correct error message in validate_leafs - "need > 2" to "need >= 2"#80
Open
sueun-dev wants to merge 1 commit intoolivmath:mainfrom
Open
fix: correct error message in validate_leafs - "need > 2" to "need >= 2"#80sueun-dev wants to merge 1 commit intoolivmath:mainfrom
sueun-dev wants to merge 1 commit intoolivmath:mainfrom
Conversation
The validate_leafs function raises an exception when `size < 2` (i.e., when there are fewer than 2 leaves). However, the error message says "need > 2", which is incorrect and misleading. The condition `size < 2` means the minimum valid size is 2 (i.e., size >= 2 is required). The error message should say "need >= 2", not "need > 2". The current message incorrectly implies that even 2 leaves would be invalid. This fix corrects the error message to accurately reflect the validation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validate_leafs function raises an exception when
size < 2(i.e., when there are fewer than 2 leaves). However, the error message says "need > 2", which is incorrect and misleading.The condition
size < 2means the minimum valid size is 2 (i.e., size >= 2 is required). The error message should say "need >= 2", not "need > 2". The current message incorrectly implies that even 2 leaves would be invalid.This fix corrects the error message to accurately reflect the validation logic.