removed ID and added more data from google - #134
Open
otherjohn wants to merge 1 commit into
Open
Conversation
I removed the required $this.ID since it caused issues when the component was danamically created multiple places on the same page. Worked great on just using Ref. I also added more data to formatedResults. Things like formated_address, place_id, and google_url allow this component much more use. Signed-off-by: otherjohn <john.hamman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the required $this.ID since it caused issues when the component was danamically created multiple places on the same page. Worked great on just using Ref. I also added more data to formatedResults. Things like formated_address, place_id, and google_url allow this component much more use.
Signed-off-by: otherjohn john.hamman@gmail.com