This repository was archived by the owner on Oct 29, 2021. It is now read-only.
Issue: 87 Adding gzip support for all requests#90
Open
Rushit wants to merge 1 commit intoolebedev:masterfrom
Open
Issue: 87 Adding gzip support for all requests#90Rushit wants to merge 1 commit intoolebedev:masterfrom
Rushit wants to merge 1 commit intoolebedev:masterfrom
Conversation
Owner
|
Hi @Rushit, thanks for the contribution! |
Author
|
@olebedev I will fix the tests on this PR. |
|
Thanks man! I eventually got gzip working with echo's gzip middleware, but to do that I had to move bundle.js away from the binary. Is there any reason from performance point of view to keep bundle.js in bindata? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add support for gzip to address - #87
@olebedev