Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 20, 2026

Currently, the helper 'createActions' pre-sorts a list of menuRegistry entries but this sort is not applied to the children (which can be generated dynamically). It never showed up as we rarely add children entries from different sources and their sequence often matches the order of insertion in the registry.

Task: 5452669

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 5452669

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7708

@robodoo
Copy link
Collaborator

robodoo commented Jan 20, 2026

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 20, 2026

@rrahir @LucasLefevre cherrypicking of pull request #7708 failed.

stdout:

Auto-merging src/actions/action.ts
Auto-merging tests/menus/menu_items_registry.test.ts
CONFLICT (content): Merge conflict in tests/menus/menu_items_registry.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Currently, the helper 'createActions' pre-sorts a list of menuRegistry
entries but this sort is not applied to the children (which can be
generated dynamically). It never showed up as we rarely add children
entries from different sources and their sequence often matches the
order of insertion in the registry.

Task: 5452669
X-original-commit: 7c8456d
@rrahir rrahir force-pushed the 18.0-17.0-fix-action-children-order-rar-487184-fw branch from 251d6f8 to 5e33c5b Compare January 20, 2026 13:16
@rrahir
Copy link
Collaborator

rrahir commented Jan 20, 2026

robodoo r+

robodoo pushed a commit that referenced this pull request Jan 20, 2026
Currently, the helper 'createActions' pre-sorts a list of menuRegistry
entries but this sort is not applied to the children (which can be
generated dynamically). It never showed up as we rarely add children
entries from different sources and their sequence often matches the
order of insertion in the registry.

closes #7817

Task: 5452669
X-original-commit: 7c8456d
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Jan 20, 2026
@fw-bot fw-bot deleted the 18.0-17.0-fix-action-children-order-rar-487184-fw branch January 27, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants