Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/actions/action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ export function createAction(item: ActionSpec): Action {
return children
.map((child) => (typeof child === "function" ? child(env) : child))
.flat()
.map(createAction);
.map(createAction)
.sort((a, b) => a.sequence - b.sequence);
}
: () => [],
isReadonlyAllowed: item.isReadonlyAllowed || false,
Expand Down
31 changes: 31 additions & 0 deletions tests/menus/menu_items_registry.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Model } from "../../src";
import { createActions } from "../../src/actions/action";
import { FONT_SIZES } from "../../src/constants";
import { functionRegistry } from "../../src/functions";
import { zoneToXc } from "../../src/helpers";
Expand Down Expand Up @@ -63,6 +64,7 @@ describe("Menu Item Registry", () => {
id: name,
name: name,
execute: () => {},
sequence: 1,
}));
});
const env = makeTestEnv();
Expand Down Expand Up @@ -1743,3 +1745,32 @@ describe("Menu Item actions", () => {
});
});
});

test("Menu children are sorted by sequence", async () => {
const env = makeTestEnv();
const menuItems = createActions([
{
id: "menu_1",
name: "Menu 1",
sequence: 20,
children: [
{
id: "secondItem",
name: "bigger sequence Item",
sequence: 30,
execute: () => {},
},
{
id: "firstItem",
name: "lower sequence Item",
sequence: 10,
execute: () => {},
},
],
},
]);

const children = menuItems[0].children(env);
expect(children[0].id).toBe("firstItem");
expect(children[1].id).toBe("secondItem");
});