[IMP] Cells: set explicit style on hyperlink-like content #7634

rrahir · 2025-12-12T11:42:16Z

Currently, we apply a custom style to the cells that contain a content similar to a hyper/markdown link during the rendering process. This means that this style disappears once we export the spreadsheet to other formats (.xlsx for instance ). Furthermore, the detection depends on the elements added to urlRegistry.

In some cases (specifically when loading a spreadsheet in a public page in Odoo) we might populate this registry differently, which leads to a difference of behaviour between renderers of the same raw content.

Since the style was computed during the rendering process, it means that you could not just "get rid" of that style, you had to define a dedicated style to override it, so 'clear format' would never work.

This revision changes our strategy and tries to explicitely apply a specific style when adding a content detected as a hyperlink/markdownling. This way, we ensure that the style is hardcoded in the data and will be consistent when we export it in .xslx files or if we show it on a public page in Odoo.

Task: 5410289

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 5410289

review checklist

robodoo · 2025-12-12T11:42:19Z

fdamhaut

🇫🇷 commentaires en Alexispeech 🇫🇷 et bug avec le reload cf task pad

fdamhaut · 2025-12-16T12:19:47Z

packages/o-spreadsheet-engine/src/migrations/migration_steps.ts

+    for (const xc in sheet.cells || {}) {
+      const content = sheet.cells[xc];
+      if (content && (isMarkdownLink(content) || isWebLink(content))) {
+        // debugger;


fdamhaut · 2025-12-16T12:20:37Z

src/components/link/link_editor/link_editor.ts

    const label = this.link.label
      ? canonicalizeNumberContent(this.link.label, locale)
      : this.link.url;
+    // TODORAR add this feature to UPDATE_CELL in the composr as well ?


fdamhaut · 2026-01-13T09:43:01Z

packages/o-spreadsheet-engine/src/migrations/migration_steps.ts

+    for (const xc in sheet.cells || {}) {
+      const content = sheet.cells[xc];
+      if (content && (isMarkdownLink(content) || isWebLink(content))) {
+        // debugger;


packages/o-spreadsheet-engine/src/helpers/data_normalization.ts

Currently, we apply a custom style to the cells that contain a content similar to a hyper/markdown link during the rendering process. This means that this style disappears once we export the spreadsheet to other formats (.xlsx for instance ). Furthermore, the detection depends on the elements added to `urlRegistry`. In some cases (specifically when loading a spreadsheet in a public page in Odoo) we might populate this registry differently, which leads to a difference of behaviour between renderers of the same raw content. Since the style was computed during the rendering process, it means that you could not just "get rid" of that style, you had to define a dedicated style to override it, so 'clear format' would never work. This revision changes our strategy and tries to explicitely apply a specific style when adding a content detected as a hyperlink/markdownling. This way, we ensure that the style is hardcoded in the data and will be consistent when we export it in .xslx files or if we show it on a public page in Odoo. Task: 5410289

hokolomopo

👋

Not 100% sure:

Evaluated links (eg. =CONCAT("www.google" , ".com"), =If(A1, HYPERLINK(...)) don't work ATM, but with this strategy we have the guarantee that they will never work.
We should change every place where we can insert cell content (so also the clipboard), not just the composer.
(not sure I understood your commit message correctly) if the urlRegistry is wrong for odoo public spreadsheet, your fix is not enough. The urlRegistry is also used to know if we should display a link popup/what happen on cell click, and those should also work in public spreadsheet.

Maybe its not worth, but I'd add a LinkUIPlugin if we really want to improve the handling of links. It could handle xlsx export/CLEAR_FORMATTING handling, and return a computed style based on the evaluation. I'm not sure links should be mentioned in core at all.

To discuss

hokolomopo · 2026-01-29T12:56:40Z

packages/o-spreadsheet-engine/src/migrations/migration_steps.ts

+  })
+  .add("19.2.0", {
+    migrate(data: WorkbookData): any {
+      return addHyperlinkStyle(data);


you'd also have to do an odoo migration PR if we want to be correct

hokolomopo · 2026-01-29T12:57:18Z

packages/o-spreadsheet-engine/src/migrations/migration_steps.ts

+  for (const sheet of data.sheets || []) {
+    for (const xc in sheet.cells || {}) {
+      const content = sheet.cells[xc];
+      if (content && (isMarkdownLink(content) || isWebLink(content))) {


hasHyperlinkContent ?

hokolomopo · 2026-01-29T12:58:12Z

packages/o-spreadsheet-engine/src/helpers/misc.ts

 }

+export function hasHyperlinkContent(content: string): boolean {
+  return isMarkdownLink(content) || isWebLink(content) || content.startsWith("=HYPERLINK(");


So it doens't work anymore for =IF(A1, HYPERLINK(...))

Edit: oh it never worked in the first place. Probably it should work ?

it does work but requires the protocol prefix ^^
=IF(TRUE, CONCAT("https://", "google.com")) works

This comment was marked as resolved.

Sign in to view

fdamhaut requested changes Dec 16, 2025

View reviewed changes

rrahir force-pushed the master-force-link-color-as-a-true-style-rar branch from 152e2cb to 36f5691 Compare December 24, 2025 09:50

rrahir force-pushed the master-force-link-color-as-a-true-style-rar branch from 36f5691 to 11f3ceb Compare January 12, 2026 07:05

fdamhaut reviewed Jan 13, 2026

View reviewed changes

rrahir force-pushed the master-force-link-color-as-a-true-style-rar branch from 11f3ceb to 557d17a Compare January 14, 2026 06:33

rrahir force-pushed the master-force-link-color-as-a-true-style-rar branch from 557d17a to 7b0aec2 Compare January 14, 2026 06:50

hokolomopo reviewed Jan 29, 2026

View reviewed changes

[IMP] Cells: set explicit style on hyperlink-like content #7634

Are you sure you want to change the base?

[IMP] Cells: set explicit style on hyperlink-like content #7634

Uh oh!

Conversation

rrahir commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

review checklist

Uh oh!

robodoo commented Dec 12, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

fdamhaut left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hokolomopo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rrahir commented Dec 12, 2025 •

edited

Loading

fdamhaut left a comment •

edited

Loading

hokolomopo left a comment •

edited

Loading