Removes query-level caching from QueryBuilder#655
Removes query-level caching from QueryBuilder#655Samuell1 wants to merge 1 commit intooctobercms:4.xfrom
Conversation
|
No real benefit in removing this. It is used in Twig, {% set records = model.where('foo', 'bar').remember(20).get() %} |
|
From my point it too much depends on query what needs to cache because just this line Maybe move it to trait, then it can be used on model where people need it. Thats why i added is as draft, to maybe add more to it or rethink this :) |
|
Twig doesn't have closures so this is why we kept it. Laravel removed it for the same reasons you mention, it can't serve every possible combination of query. It serves simple use cases very well, though. I'm not sure it is possible to make a trait for the query builder. |
|
I will try to look into it for best possible solution to dont limit performance improvements and code quality. |
No description provided.