Conversation
Contributor
Author
|
There is a problem (reported by @dannywillems) with type-checking client values, and probably injections. It is because the new preprocessing pipeline introduces unpredictable intermediate filenames, impacting our auto-generated names for client fragments. To be fixed tomorrow. |
Drup
reviewed
Dec 13, 2016
src/tools/utils.ml
Outdated
| let preprocess_opt ?(ocaml = false) ?kind opts = | ||
| let refmt () = | ||
| if !use_refmt then | ||
| [ "-pp" ; "refmt -parse re -print ml" ] |
Member
There was a problem hiding this comment.
Should we try to provide a clean failure when reason is not installed ?
Contributor
Author
There was a problem hiding this comment.
Probably. We just need to look for refmt (the only thing we really need) at the time -reason is provided.
Edit: that turns out to be quite complicated, and the compiler itself prints a reasonable message about refmt failing. So, not a priority right now.
Member
|
Nice work! |
Contributor
Author
When using refmt, we end up with intermediate filenames that break our identifier generation.
Contributor
Author
|
See #504. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides very rough and mostly untested Reason support.
I added a
-reasonflag to our compiler wrappers. It is implemented by callingrefmtas a preprocessor.There is a new
basic.reasontemplate that uses Reason syntax.