Avoid trying to be too clever when upgrading switches from opam 2.0#5002
Closed
kit-ty-kate wants to merge 3 commits intomasterfrom
Closed
Avoid trying to be too clever when upgrading switches from opam 2.0#5002kit-ty-kate wants to merge 3 commits intomasterfrom
kit-ty-kate wants to merge 3 commits intomasterfrom
Conversation
Member
|
I don't really have an opinion on removing the magic... the cases pointed out in the above are very specific to a convoluted CI setup, and the code might still be helpful for normal users (the "remove the constraint" part was intended for system compilers, where I think it results in a better UX) ; then again, magic is bad in general and being conservative as proposed ensures that the behaviour remains similar after the opam version bump. In the end my main worry is that it may be late to change this: we may start having the issue of both choices , depending on the migration path followed by the user... |
eafb71d to
d935750
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4501
See ocurrent/opam-repo-ci#148
See ocurrent/docker-base-images#150
I don’t see any good reason for trying to guess what the user meant instead of letting the user choose what they want afterward.
Transforming a 2.0 switch to
"<compiler-package>"(without constraint) is dangerous (as shown above)Transforming a 2.0 switch to
"<compiler-package>" {>= "<current-version>"}is equally dangerous as it breaks switches named after its current compiler if the compiler is the latest. We can’t assume people with the latest compiler always want the latest