use correct -short-paths config for merlin#1579
Open
SkySkimmer wants to merge 1 commit intoocaml:masterfrom
Open
use correct -short-paths config for merlin#1579SkySkimmer wants to merge 1 commit intoocaml:masterfrom
SkySkimmer wants to merge 1 commit intoocaml:masterfrom
Conversation
Fix ocaml#1395 The default needs to be `real_paths = true` (from `Mconfig.initial`), because `get_external_config` (called in `config`) will modify the config from the ocaml flags which will not contain a negated `-short-paths` when short paths are not wanted.
Author
|
Not sure how adding tests works here but a pair of tests (with / without short paths) should probably be added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1395
The default needs to be
real_paths = true(fromMconfig.initial), becauseget_external_config(called inconfig) will modify the config from the ocaml flags which will not contain a negated-short-pathswhen short paths are not wanted.Should backport cleanly to 414-LTS (or rather I tested on 414-LTS then moved the commit on top of master ;))