Open
Conversation
voodoos
force-pushed
the
fix-issue-1388
branch
from
9342ac5 to
e1f7659
Compare
|
I've tested and it does not work. In merlin-log buffer: The corresponding flags stanza: It compiles fine with |
Collaborator
Author
|
Are you sure your editor plugin uses the Merlin from this branch ? One way to do that is to use an opam pin: |
|
yes, this is how I tested. |
Collaborator
Author
|
Ok. Unfortunately I am not able to reproduce a similar issue on my test project any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1388.
This necessitate an update of
dot-merlin-reader.I did not test with
dune ocaml-merlin.@vzaliva could you try this branch and confirm whether it solves your issue ? Thank you !