RFC: don't fail on directives when the file starts with #!#1134
Open
hnrgrgr wants to merge 4 commits intoocaml:mainfrom
Open
RFC: don't fail on directives when the file starts with #!#1134hnrgrgr wants to merge 4 commits intoocaml:mainfrom
#!#1134hnrgrgr wants to merge 4 commits intoocaml:mainfrom
Conversation
Author
|
Ok, I clearly missed the point on handling multiple compiler version. And I missed the tricks used until ocaml-4.07 to handle What's the policy about modifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR tries to fix #1023 .
When a file starts with
#!it is now parsed withParser_raw.Incremental.use_fileinstead of the usualParser_raw.Incremental.implementation.In the first patch, all the toplevel directives are ignored. The second patch adds handling of
#require. The third and last patch drafts an implementation of#useand#mod_use.