Skip to content

fix(apps): publish port-only install endpoints - #771

Open
luckycrm wants to merge 1 commit into
oblien:mainfrom
luckycrm:fix/app-port-only-publish
Open

fix(apps): publish port-only install endpoints#771
luckycrm wants to merge 1 commit into
oblien:mainfrom
luckycrm:fix/app-port-only-publish

Conversation

@luckycrm

Copy link
Copy Markdown

Summary

  • persist fixed all-interface host bindings for catalog endpoints explicitly selected as port-only
  • preserve catalog-authored host remaps and protocols while leaving domain-mode endpoints unpublished
  • repair the binding when retrying an existing failed install draft
  • add regression coverage for Supabase Kong and generic remapped ports

Fixes #770.

Why

The app installer stored the routing choice but did not add a Docker host-port mapping. For Supabase, Kong therefore had no public URL, leaving GOTRUE_SITE_URL, API_EXTERNAL_URL, and SUPABASE_PUBLIC_URL unset and causing the deployment warning.

Verification

  • bunx vitest run test/modules/apps/app-install-routing.test.ts (15 passed)
  • bun run lint in apps/api
  • full API test run: 5,157 passed, 3 skipped; the two sandbox-blocked test files were rerun with host permissions (33 passed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App installer port-only mode does not publish a host port

1 participant