Ignore ordering of openid token in scope parameter#48
Open
jimrobinson wants to merge 1 commit intooauth2-proxy:mainfrom
Open
Ignore ordering of openid token in scope parameter#48jimrobinson wants to merge 1 commit intooauth2-proxy:mainfrom
jimrobinson wants to merge 1 commit intooauth2-proxy:mainfrom
Conversation
Change the logic that checks for the "openid" token in the "scope" parameter value to ignore ordering. The Scopes section of the specification appears to only require that "openid" be present in the list, not that it be the first item in the list: OpenID Connect Basic Client Implementer's Guide 1.0 - draft 47 2.4. Scope Values https://openid.net/specs/openid-connect-basic-1_0.html#Scopes
|
Thank you, I have merged your PR into my fork @ xrstf/mockoidc. In case anyone is interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the logic that checks for the "openid" token in the "scope" parameter value to ignore ordering. The Scopes section of the specification appears to only require that "openid" be present in the list, not that it be the first item in the list:
OpenID Connect Basic Client Implementer's Guide 1.0 - draft 47
2.4. Scope Values
https://openid.net/specs/openid-connect-basic-1_0.html#Scopes