fix: In case when Keycloack configured, if you create a user with non-ascii names (first name, last name, e-mail address) then these names will be displayed using non-readable symbols in the list of users in the Administration console.#960
Open
sermakov-orion wants to merge 1 commit intooVirt:masterfrom
Open
Conversation
##Fixes issue In case when Keycloack configured, if you create a user with non-ascii names (first name, last name, e-mail address) then these names will be displayed using non-readable symbols in the list of users in the Administration console. ##Changes introduced with this PR In case when External SSO is configured we re-encode the names from ISO_8859_1 to UTF8 ##Are you the owner of the code you are sending in, or do you have permission of the owner? Yes
sermakov-orion
requested review from
ahadas,
bennyz,
didib,
emesika,
michalskrivanek,
mwperina,
sgratch and
smelamud
as code owners
0ffer
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Ermakov sermakov@orionsoft.ru
Fixes issue
In case when Keycloack configured, if you create a user with non-ascii names (first name, last name, e-mail address) then these names will be displayed using non-readable symbols in the list of users in the Administration console.
Changes introduced with this PR
In case when External SSO is configured we re-encode the names from ISO_8859_1 to UTF8
Are you the owner of the code you are sending in, or do you have permission of the owner?
Yes