ARM support engine changes by shubhaOracle · Pull Request #1063 · oVirt/ovirt-engine

shubhaOracle · 2025-09-18T02:00:49Z

Signed-off-by: ShubhaOracle [email protected]

Fixes issue # (delete if not relevant)

Changes introduced with this PR

Updated the engine code to add support for ARM/aarch64 support. Added new architecture type, bios type, and 'virt' for CPU model detection.
Associated VDSM changes are added with PR ARM support VDSM changes vdsm#436

Are you the owner of the code you are sending in, or do you have permission of the owner?

[y/n]Yes

Signed-off-by: ShubhaOracle <[email protected]>

dupondje

I am also missing tests.
Cause nothing is added to tests now...

dupondje · 2026-01-26T10:02:33Z

.../manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java

                .when(FeatureSupported.isBiosTypeSupported(eCluster.getCompatibilityVersion())
                    && eCluster.getBiosType() != null
                    && eCluster.getBiosType() != BiosType.I440FX_SEA_BIOS
+                    && eCluster.getBiosType() != BiosType.AMPERE


We should validate BiosType together with Architecture.
So that you don't select BiosType.AMPERE on X86 for example.

Next to that, name the BiosType VIRT/VIRT_AAVMF ?
This patch is not ampere-only...

dupondje · 2026-01-26T10:02:47Z

.../manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java

    public ValidationResult nonDefaultBiosType() {
        Cluster eCluster = newCluster != null ? newCluster : cluster;
        ArchitectureType architecture = getArchitecture();
        return ValidationResult.failWith(EngineMessage.NON_DEFAULT_BIOS_TYPE_FOR_X86_ONLY)


Error message should also change then.

dupondje · 2026-01-26T10:02:55Z

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java

    public static ValidationResult isBiosTypeSupported(VmBase vmBase, Cluster cluster, OsRepository osRepository) {
        if (FeatureSupported.isBiosTypeSupported(cluster.getCompatibilityVersion())
                && vmBase.getBiosType() != BiosType.I440FX_SEA_BIOS
+                && vmBase.getBiosType() != BiosType.AMPERE


dupondje · 2026-01-26T10:04:38Z

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java

            }

+            // For aarch64, always use host cpu flags
+            if (getCluster().getArchitecture().getFamily() == ArchitectureType.aarch64) {


I would not do it this way.
When adding the CPU in the ServerCPUList in packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql, I would for example there put no CPU flags.
If you then create a VM with a CPU without CPU flags, it should use auto-passtrough/host cpu flags.

This has the advantage that in the future we can just add new ARM CPU's without messing in the code again.

dupondje · 2026-01-26T10:05:22Z

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java

                        } else if (sc.getFlags().contains(CpuVendor.IBMS390.getFlag())) {
                            s390CpuByNameDictionary.put(sc.getCpuName(), sc);
                            s390CpuByVdsNameDictionary.put(sc.getVdsVerbData(), sc);
+                        } else if (sc.getFlags().contains(CpuVendor.ARM.getFlag())) {


I would name it AARCH64 instead of ARM

dupondje · 2026-01-26T10:17:37Z

...icommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java


    protected void buildModel(VmBase vmBase,
-                              BuilderExecutor.BuilderExecutionFinished<VmBase, UnitVmModel> callback) {
+            BuilderExecutor.BuilderExecutionFinished<VmBase, UnitVmModel> callback) {


Unneeded change

dupondje · 2026-01-26T10:18:25Z

packaging/conf/osinfo-defaults.properties

+os.ubuntu_16_04_aarch64.id.value = 3006
+os.ubuntu_16_04_aarch64.name.value = Ubuntu Xenial Xerus LTS+
+os.ubuntu_16_04_aarch64.derivedFrom.value = other_linux_aarch64
+


We should add some more/recent OS'es

dupondje · 2026-01-26T10:18:51Z

packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql

 select fn_db_update_config_value('ClusterEmulatedMachines','pc-q35-rhel8.1.0,pc-q35-4.1,pc-i440fx-rhel7.6.0,pc-i440fx-2.12,pseries-rhel8.1.0,s390-ccw-virtio-2.12','4.4');
 select fn_db_update_config_value('ClusterEmulatedMachines','pc-q35-rhel8.3.0,pc-q35-4.1,pc-i440fx-rhel7.6.0,pc-i440fx-2.12,pseries-rhel8.3.0,s390-ccw-virtio-2.12','4.5');
+-- aarch64 emulated machine types
+select fn_db_update_config_value('ClusterEmulatedMachines','pc-q35-rhel8.6.0,pc-q35-4.1,pc-i440fx-rhel7.6.0,pc-i440fx-2.12,pseries-rhel8.4.0,s390-ccw-virtio-2.12,virt,virt-6.0,virt-6.1,virt-6.2','4.7');


What virt types does qemu-aarch64 had on RHEL9 and RHEL10?

dupondje · 2026-01-26T10:19:01Z

packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql

 select fn_db_update_config_value('IsMigrationSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true"}','4.2');
 select fn_db_update_config_value('IsMemorySnapshotSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true"}','4.2');
 select fn_db_update_config_value('IsSuspendSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true"}','4.2');
+select fn_db_update_config_value('IsMigrationSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true", "aarch64" : "true"}','4.7');                                                                                                             +select fn_db_update_config_value('IsMemorySnapshotSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true", "aarch64" : "true"}','4.7');


Invalid line

dupondje · 2026-01-26T10:19:47Z

packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql

 select fn_db_update_config_value('IsMemorySnapshotSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true"}','4.2');
 select fn_db_update_config_value('IsSuspendSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true"}','4.2');
+select fn_db_update_config_value('IsMigrationSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true", "aarch64" : "true"}','4.7');                                                                                                             +select fn_db_update_config_value('IsMemorySnapshotSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true", "aarch64" : "true"}','4.7');
+select fn_db_update_config_value('IsSuspendSupported','{"undefined": "true", "x86": "true", "ppc" : "true", "s390x" : "true", "aarch64" : "true"}','4.7');


Do we only want to support 4.7 ? (Now already 4.8).

ARM support engine changes

2d4df3d

Signed-off-by: ShubhaOracle <[email protected]>

shubhaOracle requested review from ahadas, bennyz, didib, emesika, michalskrivanek, sgratch and smelamud as code owners September 18, 2025 02:00

shubhaOracle mentioned this pull request Sep 18, 2025

ARM support VDSM changes oVirt/vdsm#436

Open

JasperB-TeamBlue assigned shubhaOracle Sep 19, 2025

JasperB-TeamBlue requested review from JasperB-TeamBlue, dupondje and peter-boden September 19, 2025 07:20

dupondje mentioned this pull request Oct 22, 2025

how to use ovirt-engine on a new Architecture #574

Closed

dupondje requested changes Jan 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARM support engine changes#1063

ARM support engine changes#1063
shubhaOracle wants to merge 1 commit intooVirt:masterfrom
shubhaOracle:arm-changes

shubhaOracle commented Sep 18, 2025 •

edited

Loading

Uh oh!

dupondje left a comment

Uh oh!

dupondje Jan 26, 2026

Uh oh!

dupondje Jan 26, 2026

Uh oh!

dupondje Jan 26, 2026

Uh oh!

dupondje Jan 26, 2026

Uh oh!

dupondje Jan 26, 2026

Uh oh!

dupondje Jan 26, 2026

Uh oh!

dupondje Jan 26, 2026

Uh oh!

dupondje Jan 26, 2026

Uh oh!

dupondje Jan 26, 2026

Uh oh!

dupondje Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

shubhaOracle commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes introduced with this PR

Are you the owner of the code you are sending in, or do you have permission of the owner?

Uh oh!

dupondje left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shubhaOracle commented Sep 18, 2025 •

edited

Loading