webadmin: add possibility for UI plugins to set hidden search string for lists#1004
Open
0ffer wants to merge 1 commit intooVirt:masterfrom
Open
webadmin: add possibility for UI plugins to set hidden search string for lists#10040ffer wants to merge 1 commit intooVirt:masterfrom
0ffer wants to merge 1 commit intooVirt:masterfrom
Conversation
JasperB-TeamBlue
requested review from
JasperB-TeamBlue,
dupondje and
sandrobonazzola
and removed request for
sgratch
0ffer
force-pushed
the
hidden-search-filter-for-ui-plugins
branch
from
cbacd82 to
832257b
Compare
Contributor
Author
|
On local stand it can be checked within browser console. And I prepared some short demo for this function: |
…for lists It is useful for plugins that control displayed list models with search string. Configured string will be applied as hidden filter for each search request to the backend. And user can't change it by mistake if he need secondary filtration. It is important that hidden filter should be simple. If it has some `or` expressions then result filter(with user defined search string and tags) can return not expected results (because search string don't have any operation priority) Signed-off-by: Stanislav Melnichuk <melnichuk.stas@gmail.com>
0ffer
force-pushed
the
hidden-search-filter-for-ui-plugins
branch
from
832257b to
ffbb931
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is useful for plugins that control displayed list models with search string. Configured string will be applied as hidden filter for each search request to the backend. And user can't change it by mistake if he need secondary filtration. It is important that hidden filter should be simple. If it has some
orexpressions then result filter(with user defined search string and tags) can return not expected results (because search string don't have any operation priority)Are you the owner of the code you are sending in, or do you have permission of the owner?
[y/n] -> yes