Replace as-cast with u32::try_from in SRS creation#3483
Open
dannywillems wants to merge 2 commits intomasterfrom
Open
Replace as-cast with u32::try_from in SRS creation#3483dannywillems wants to merge 2 commits intomasterfrom
dannywillems wants to merge 2 commits intomasterfrom
Conversation
Replace `#[allow(clippy::cast_possible_truncation)]` with `u32::try_from(i).unwrap()` in SRS creation, making the depth bound check explicit at runtime rather than silently truncating.
dannywillems
force-pushed
the
dw/explicit-u32-cast
branch
from
9b35e9f to
6e1cfbd
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[allow(clippy::cast_possible_truncation)]+i as u32withu32::try_from(i).unwrap()in bothcreate_parallelandcreateSRS methodsAddresses Richard's review feedback on #3480.
Test plan
cargo clippy --all-targets --all-featurespasses cleanser_regression_canonical_*)