Conversation
Request contract name in lowercase.
…CoordinatorAgent will be using eth endpoints, and based on updates made for cross-chain support.
There was a problem hiding this comment.
Pull Request Overview
This PR adds signing functionality by introducing a dedicated signing ritual state as well as related embed formatting and command handling. Key changes include:
- Introducing a new SigningRitualState enum in models.py to track signing ritual statuses.
- Adding signing ritual embed formatting and a corresponding command in embeds.py and commands.py.
- Updating agent registration, constants, and dependency references to support the signing feature.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| models.py | Adds SigningRitualState enum with new states for signing rituals |
| embeds.py | Introduces add_participants helper and signing ritual embed formatting |
| constants.py | Updates BASE_URL to point to a new repository branch |
| commands.py | Adds signing_ritual_command to handle signing ritual requests |
| bot.py | Adds and updates Infura endpoints, including new mainnet and sepolia keys |
| agents.py | Updates agent registration (_TRACK mapping) to include SigningCoordinatorAgent |
| Pipfile | Updates nucypher dependency reference to the signing branch |
| color_map = { | ||
| 'ACTIVE': 0x00FF00, | ||
| 'EXPIRED': 0xFF0000, | ||
| 'PENDING': 0xFFA500 |
There was a problem hiding this comment.
The color mapping refers to a 'PENDING' state which is not defined in the SigningRitualState enum. Consider either adding a PENDING state to the enum or updating the mapping to use an existing state.
Update base python docker image to use debian trixie version (latest) Specify python version 3.12 in Pipfile.
…ucypher/nucypher-contracts.
…dependency can be built and installed.
Updated signing infra
|
I think we should just merge this into |
manumonti
left a comment
manumonti
left a comment
There was a problem hiding this comment.
LGTM! This code is what it has been running on Discord bot until now, right?
Correct. |
Add functionality for TACo Action Control (signing product)