Skip to content

Add CAUTION section in Compatibility argument matchers documentation#954

Merged
304NotModified merged 2 commits intonsubstitute:mainfrom
Romfos:compat_warning
Mar 15, 2026
Merged

Add CAUTION section in Compatibility argument matchers documentation#954
304NotModified merged 2 commits intonsubstitute:mainfrom
Romfos:compat_warning

Conversation

@Romfos
Copy link
Copy Markdown
Contributor

@Romfos Romfos commented Mar 15, 2026 •
edited
Loading

Changes:

  • Add CAUTION section in Compatibility argument matchers documentation
image

Related: #830, #953

@Romfos Romfos marked this pull request as ready for review March 15, 2026 11:45
@304NotModified
Copy link
Copy Markdown
Contributor

304NotModified commented Mar 15, 2026

I missed it I guess, but is next major version 6 or 7?

Anyway, maybe change the text to make it more explicit :)

@Romfos
Copy link
Copy Markdown
Contributor Author

Romfos commented Mar 15, 2026 •
edited
Loading

This api was obsolete is V6

Documentation release was decoupled from package release.
It was made intentionally (you don't need to release package to add new examples\articles\e.t.c)
Make sense to start warn people about potential changes in future
(maybe this will be removed in V7, but we don't have a roadmap for V7 for now, this is discussable).

304NotModified
304NotModified reviewed Mar 15, 2026
View reviewed changes
Comment thread docs/help/compat-args/index.md Outdated
@304NotModified
Copy link
Copy Markdown
Contributor

304NotModified commented Mar 15, 2026

I've added a suggestion:)

@304NotModified 304NotModified merged commit 00871cc into nsubstitute:main Mar 15, 2026
4 checks passed
@Romfos Romfos deleted the compat_warning branch March 16, 2026 14:51
@Romfos
Copy link
Copy Markdown
Contributor Author

Romfos commented Mar 20, 2026

сс @tpodolak could you please release new documentation?

@304NotModified
Copy link
Copy Markdown
Contributor

304NotModified commented Mar 20, 2026 •
edited
Loading

@Romfos I think I could also do that? I triggered https://github.com/nsubstitute/NSubstitute/actions/runs/23361954112

Update I guess we need:
https://github.com/nsubstitute/nsubstitute.github.com/actions/workflows/pages/pages-build-deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

@dtchepak dtchepak Awaiting requested review from dtchepak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Romfos @304NotModified