fix(workspace): clean up owners and conformance project refs on remove#34815
fix(workspace): clean up owners and conformance project refs on remove#34815barbados-clemens wants to merge 3 commits intomasterfrom
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 1671b1a
☁️ Nx Cloud last updated this comment at |
When removing a project, also strip exact project name matches from `conformance.rules[].projects` and `owners.patterns[].projects` in nx.json so stale references don't linger. Co-Authored-By: Claude Opus 4.6 <[email protected]>
barbados-clemens
force-pushed
the
cu/remove-handles-owners-conformance-projects
branch
from
ac82355 to
028acf8
Compare
Add the owners configuration object to nx-schema.json matching the docs (format, outputPath, patterns, GitLab sections). Also update the remove generator to filter project refs from section-level patterns and handle the `owners: true` shorthand. Co-Authored-By: Claude Opus 4.6 <[email protected]>
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Add the owners configuration object to nx-schema.json matching the docs (format, outputPath, patterns, GitLab sections). Also update the remove generator to filter project refs from section-level patterns and handle the `owners: true` shorthand. Co-Authored-By: Claude Opus 4.6 <[email protected]> [Self-Healing CI Rerun]
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
We identified that the e2e-gradle:e2e-ci--src/gradle-import.test.ts failure is unrelated to this PR's changes, which are scoped entirely to the nx schema and workspace remove generator. The failure appears to stem from an environment or infrastructure issue during test setup, as the task output showed node_modules installation activity rather than a test assertion error.
No code changes were suggested for this issue.
Trigger a rerun:
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
1 participant
Current Behavior
When a project is removed via
@nx/workspace:remove, stale references to that project can remain innx.jsonunderconformance.rules[].projectsandowners.patterns[].projects.Expected Behavior
The remove generator now strips exact project name matches from:
conformance.rules[].projects— both plain string entries and{ matcher, explanation }objectsowners.patterns[].projects— plain string entriesGlob patterns (e.g.
finance-*), tag references (e.g.tag:rust), and other non-exact-match filters are left untouched.Related Issue(s)
🤖 Generated with Claude Code