chore(repo): use @nx/maven to build @nx/maven by MaxKless · Pull Request #33412 · nrwl/nx

MaxKless · 2025-11-07T16:14:25Z

Current Behavior

there is an install target calling ./mvnw directly

Expected Behavior

we use the @nx/maven plugin for generating maven targets

vercel · 2025-11-07T16:14:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
nx-dev	Ready	Preview	Jan 16, 2026 4:12pm

netlify · 2025-11-07T16:14:30Z

✅ Deploy Preview for nx-docs ready!

Name	Link
🔨 Latest commit	`f0f336c`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-docs/deploys/69b44d30f7fe8d000870c353
😎 Deploy Preview	https://deploy-preview-33412--nx-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-11-07T16:15:07Z

View your CI Pipeline Execution ↗ for commit f0f336c

Command	Status	Duration	Result
`nx affected --targets=lint,test,build,e2e,e2e-c...`	❌ Failed	22m 50s	View ↗
`nx run-many -t check-imports check-lock-files c...`	✅ Succeeded	4m 11s	View ↗
`nx-cloud record -- nx-cloud conformance:check`	✅ Succeeded	8s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	1s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-13 18:13:13 UTC

graphite-app · 2025-11-17T11:16:02Z

pnpm-lock.yaml

+      '@nx/maven':
+        specifier: 22.1.0-rc.2
+        version: 22.1.0-rc.2([email protected](@swc-node/[email protected](@swc/[email protected](@swc/[email protected]))(@swc/[email protected])([email protected]))(@swc/[email protected](@swc/[email protected])))


Version mismatch detected: package.json specifies @nx/maven: 22.1.0-rc.3 but pnpm-lock.yaml has locked version 22.1.0-rc.2. This mismatch will cause the wrong version to be installed.

# Fix by running: pnpm install # This will update the lockfile to match package.json

The lockfile must be regenerated to match the version specified in package.json to ensure consistent installations across environments.

Spotted by Graphite Agent

Is this helpful? React 👍 or 👎 to let us know.

AgentEnder · 2025-11-17T19:01:27Z

.github/workflows/ci.yml

+      - name: Show project graph
+        run: npx nx show project nx-maven-plugin | jq .targets.test
+


for sure once debugging is done I'll remove it 👍

nx-cloud

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud is proposing a fix for your failed CI:

These changes fix the e2e test failure by updating the test expectations to align with the PR's intent of using simple artifactId names instead of full Maven coordinates. The test was expecting project graph nodes named 'com.example:app' but the new implementation uses just 'app', causing the test to fail when verifying dependencies.

Note

⏳ We are verifying this fix by re-running e2e-maven:e2e-ci--src/maven.test.ts.

diff --git a/e2e/maven/src/maven.test.ts b/e2e/maven/src/maven.test.ts
index 812ab78da9..42b04eaf85 100644
--- a/e2e/maven/src/maven.test.ts
+++ b/e2e/maven/src/maven.test.ts
@@ -71,15 +71,15 @@ describe('Maven', () => {
     const graph = readJson('graph.json');
 
     // Check that dependencies exist in the graph
-    const appDeps = graph.graph.dependencies['com.example:app'];
+    const appDeps = graph.graph.dependencies['app'];
     expect(appDeps).toContainEqual({
-      source: 'com.example:app',
-      target: 'com.example:lib',
+      source: 'app',
+      target: 'lib',
       type: 'static',
     });
     expect(appDeps).toContainEqual({
-      source: 'com.example:app',
-      target: `com.example:${mavenProjectName}`,
+      source: 'app',
+      target: mavenProjectName,
       type: 'static',
     });
   });

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Or Apply changes locally with:

npx nx-cloud apply-locally ccqO-gSLE

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

nx-cloud

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud is proposing a fix for your failed CI:

Our changes fix the test failure by correcting the Nx command syntax from run mvn:compile app to run app:mvn:compile. When using colon-based target prefixes, Nx requires the format project:prefix:goal, not prefix:goal project, which was causing the "Cannot find project 'mvn'" error.

Note

⏳ We are verifying this fix by re-running e2e-maven:e2e-ci--src/maven.test.ts.

diff --git a/e2e/maven/src/maven.test.ts b/e2e/maven/src/maven.test.ts
index 87b664439b..97050d89a5 100644
--- a/e2e/maven/src/maven.test.ts
+++ b/e2e/maven/src/maven.test.ts
@@ -118,7 +118,7 @@ describe('Maven', () => {
     expect(output).toContain('- mvn:install-ci:');
 
     // Verify prefixed target works
-    const buildOutput = runCLI('run mvn:compile app --no-batch');
+    const buildOutput = runCLI('run app:mvn:compile --no-batch');
     expect(buildOutput).toContain('BUILD SUCCESS');
   });
 });

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Or Apply changes locally with:

npx nx-cloud apply-locally TDXS-4pyH

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

nx-cloud

Nx Cloud is proposing a fix for your failed CI:

We add a "Bootstrap Maven plugin" step to the CI workflow that builds and installs dev.nx.maven:nx-maven-plugin:0.0.15 to the local .m2 repository before any Nx commands run. This fixes the format:check and sync:check failures caused by the @nx/maven plugin (newly added to nx.json) being unable to resolve the Maven plugin during project graph processing. Without this step, every Nx command fails immediately because the plugin jar is not in Maven Central and not pre-installed on the CI runner.

Note

⏳ We are verifying this fix by re-running a subset of the 2 failed tasks that were analyzed.

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 041af81b..9e885e1b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -77,6 +77,9 @@ jobs:
           pnpm install --frozen-lockfile
           pnpm playwright install --with-deps
 
+      - name: Bootstrap Maven plugin
+        run: ./mvnw install -pl dev.nx.maven:nx-maven-plugin -am -DskipTests
+
       - name: Nx Report
         run:
           pnpm nx report

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Or Apply changes locally with:

npx nx-cloud apply-locally 3ZpQ-ZoO1

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

nx-cloud

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud is proposing a fix for your failed CI:

We add a "Bootstrap Maven plugin" step to the CI workflow that builds and installs dev.nx.maven:nx-maven-plugin:0.0.15 to the local .m2 repository before any Nx commands run. This fixes the format:check and sync:check failures caused by the @nx/maven plugin (newly added to nx.json) being unable to resolve the Maven plugin during project graph processing. Without this step, every Nx command fails immediately because the plugin jar is not in Maven Central and not pre-installed on the CI runner.

Tip

✅ We verified this fix by re-running nx-cloud record -- nx sync:check.

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 041af81b..9e885e1b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -77,6 +77,9 @@ jobs:
           pnpm install --frozen-lockfile
           pnpm playwright install --with-deps
 
+      - name: Bootstrap Maven plugin
+        run: ./mvnw install -pl dev.nx.maven:nx-maven-plugin -am -DskipTests
+
       - name: Nx Report
         run:
           pnpm nx report

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Or Apply changes locally with:

npx nx-cloud apply-locally 3ZpQ-ZoO1

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

Switch the Maven projects (batch-runner, batch-runner-adapters, shared, maven-plugin) to use the @nx/maven plugin's inferred targets instead of manual run-commands. Introduces nx-parent-pom to avoid circular deps, adds explicit project names, and configures mvn-package goals for the adapter shaded JARs. Co-Authored-By: Claude Opus 4.6 <[email protected]>

- Simplify e2e-maven implicit deps to just @nx/maven - Add adapter provided deps in batch-runner pom.xml for dependency inference - Use ^mvn:package in legacy-post-build instead of explicit project refs - Remove redundant projectType, tags, and implicit deps from sub-projects

The CI variant targets don't inherit overrides from their base targets, so the custom shade goals need to be specified separately.

Co-authored-by: MaxKless <[email protected]>

This reverts commit c49b726.

This reverts commit e497d6c.

Avoids colon parsing ambiguity with `nx run app:mvn:compile` by using `nx run mvn:compile app` instead.

The mvn:verify-ci target conflicts with the build target's ^mvn:package dependency, causing jar plugin to fail when shade already replaced the artifact.

Switch from ^mvn:package to ^mvn:package-ci so the build target uses the same CI pipeline as mvn:verify-ci, avoiding duplicate jar plugin invocations that conflict with the shade plugin.

…sOn" This reverts commit e1ac12c.

Shared is consumed via the shade plugin, not from the local Maven repo. Install was causing failures when build state incorrectly recorded target/classes as the main artifact.

Maven build state carries project.artifact.file between task invocations, causing jar:jar to fail when it finds the artifact already set from a previous run or cache restore.

This reverts commit 583574a.

…CI Rerun]

nx-cloud

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

View detailed reasoning in Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

_{🎓 Learn more about Self-Healing CI on nx.dev}

MaxKless requested review from a team, FrozenPandaz and vsavkin as code owners November 7, 2025 16:14

vercel bot had a problem deploying to Preview November 7, 2025 16:15 Failure

This comment was marked as outdated.

Sign in to view

MaxKless force-pushed the use-maven-plugin branch from c1afe9d to e5817c2 Compare November 14, 2025 13:46

MaxKless requested a review from lourw as a code owner November 14, 2025 13:46

vercel bot had a problem deploying to Preview November 14, 2025 13:47 Failure

This comment was marked as outdated.

Sign in to view

vercel bot had a problem deploying to Preview November 14, 2025 15:40 Failure

This comment was marked as outdated.

Sign in to view

MaxKless force-pushed the use-maven-plugin branch from 2811980 to 4085a8e Compare November 17, 2025 11:13

vercel bot had a problem deploying to Preview November 17, 2025 11:14 Failure

graphite-app bot reviewed Nov 17, 2025

View reviewed changes

MaxKless force-pushed the use-maven-plugin branch from 4085a8e to 2e912b4 Compare November 17, 2025 13:44

vercel bot deployed to Preview November 17, 2025 13:51 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview November 17, 2025 16:06 View deployment

This comment was marked as outdated.

Sign in to view

MaxKless requested a review from a team as a code owner November 17, 2025 18:50

vercel bot deployed to Preview November 17, 2025 18:54 View deployment

AgentEnder reviewed Nov 17, 2025

View reviewed changes

vercel bot deployed to Preview November 17, 2025 19:24 View deployment

vercel bot deployed to Preview November 17, 2025 19:43 View deployment

vercel bot deployed to Preview November 17, 2025 19:52 View deployment

This comment was marked as outdated.

Sign in to view

nx-cloud bot reviewed Feb 28, 2026

View reviewed changes

FrozenPandaz force-pushed the use-maven-plugin branch from a3618d2 to 702c1a9 Compare February 28, 2026 03:35

nx-cloud bot reviewed Mar 13, 2026

View reviewed changes

MaxKless and others added 24 commits March 13, 2026 11:41

review fixes wip

8277133

update nx wip

6b60ab6

chore(maven): add mvn:verify-ci to affected targets in CI

596c775

chore(maven): remove unnecessary tags from maven project.json files

d82d38b

fix(maven): add goals override for mvn:package-ci targets

afa5125

The CI variant targets don't inherit overrides from their base targets, so the custom shade goals need to be specified separately.

fix(maven): use artifactId for project names with mvn: prefix

300448d

Co-authored-by: MaxKless <[email protected]>

fix(maven): map coordinates to project names in coordinatesMap

4a9bbdb

Co-authored-by: MaxKless <[email protected]>

Revert "fix(maven): map coordinates to project names in coordinatesMap"

f7ca608

This reverts commit c49b726.

Revert "fix(maven): use artifactId for project names with mvn: prefix"

171f730

This reverts commit e497d6c.

fix(maven): use positional syntax for prefixed target in e2e test

0515a8a

Avoids colon parsing ambiguity with `nx run app:mvn:compile` by using `nx run mvn:compile app` instead.

chore(maven): remove mvn:verify-ci from CI affected targets

ebb55d6

The mvn:verify-ci target conflicts with the build target's ^mvn:package dependency, causing jar plugin to fail when shade already replaced the artifact.

chore(maven): use ^mvn:package-ci in legacy-post-build dependsOn

4ea1429

Switch from ^mvn:package to ^mvn:package-ci so the build target uses the same CI pipeline as mvn:verify-ci, avoiding duplicate jar plugin invocations that conflict with the shade plugin.

Revert "chore(maven): use ^mvn:package-ci in legacy-post-build depend…

a4b94dc

…sOn" This reverts commit e1ac12c.

chore(repo): bust cache to fix stale maven build state

b8d1804

fix(maven): skip install for nx-maven-shared

8cfcf76

Shared is consumed via the shade plugin, not from the local Maven repo. Install was causing failures when build state incorrectly recorded target/classes as the main artifact.

chore(repo): disable cache for mvn targets

c579ea9

Maven build state carries project.artifact.file between task invocations, causing jar:jar to fail when it finds the artifact already set from a previous run or cache restore.

Revert "chore(repo): disable cache for mvn targets"

4a97ba0

This reverts commit 583574a.

chore(repo): update nx version

bbaf94c

fix(maven): hardcode nx-maven-plugin version to 0.0.15

2ac7cb3

chore(repo): enable NX_VERBOSE_LOGGING in CI for debugging

1a5fb95

chore(repo): bust cache to run everything from scratch

744e3f9

chore(repo): bust cache to run everything from scratch [Self-Healing …

f0f336c

…CI Rerun]

nx-cloud bot reviewed Mar 13, 2026

View reviewed changes

		- name: Show project graph
		run: npx nx show project nx-maven-plugin \| jq .targets.test

Conversation

MaxKless commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Behavior

Expected Behavior

Uh oh!

vercel bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-docs ready!

Uh oh!

nx-cloud bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

graphite-app bot Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

AgentEnder Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

MaxKless Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

nx-cloud bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

nx-cloud bot left a comment

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

nx-cloud bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

nx-cloud bot left a comment

Choose a reason for hiding this comment

Nx Cloud has identified a flaky task in your failed CI:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MaxKless commented Nov 7, 2025 •

edited

Loading

vercel bot commented Nov 7, 2025 •

edited

Loading

netlify bot commented Nov 7, 2025 •

edited

Loading

nx-cloud bot commented Nov 7, 2025 •

edited

Loading

nx-cloud bot left a comment •

edited

Loading

nx-cloud bot left a comment •

edited

Loading

nx-cloud bot left a comment •

edited

Loading