Added ipv6 support for command wrapping#624
Open
CraftingDragon007 wants to merge 2 commits intonovnc:masterfrom
Open
Added ipv6 support for command wrapping#624CraftingDragon007 wants to merge 2 commits intonovnc:masterfrom
CraftingDragon007 wants to merge 2 commits intonovnc:masterfrom
Conversation
Contributor
|
Thanks for contributing! I'll take a look. |
Contributor
CendioZeijlon
left a comment
CendioZeijlon
left a comment
There was a problem hiding this comment.
Looks good overall, but it looks like there is both some refactoring and addition of new features.
Could you rework this a bit into separate commits to make your changes easier to follow?
Author
Yes, I also changed some other things here and there because it was needed for ipv6 (for example storing the ipv6 address)
Does it really make sense to rework changes of +47 -18 lines of code in one single file into multiple commits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the rebind.c file to also support ipv6. This allows wrapping of programs listening on ipv6 (for example: [::]:5900 or [::1]:5900)