#7847 optimize delete guests async#7869
Open
danFbach wants to merge 2 commits intonopSolutions:developfrom
Open
#7847 optimize delete guests async#7869danFbach wants to merge 2 commits intonopSolutions:developfrom
danFbach wants to merge 2 commits intonopSolutions:developfrom
Conversation
…if any results exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimizes delete guests async by breaking queries into batches.
significantly reduces chances of long running task that locks the database and blocks store main thread waiting on db.
reduces chances of failed task which results in remnant tmp_ tables.
runs faster overall since queries are entirely smaller.