build: suppress clang errors building libffi on Windows#64222
Merged
Conversation
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
Renegade334
added
windows
legendecas
approved these changes
Jun 30, 2026
Renegade334
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
StefanStojanovic
approved these changes
Jul 1, 2026
aduh95
added
the
commit-queue
richardlau
approved these changes
Jul 1, 2026
richardlau
added
fast-track
Contributor
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
Member
|
This is breaking https://github.com/nodejs/node/actions/workflows/coverage-windows.yml. It wasn't picked up when #64040 landed because it was disabled due to #63979 (addressed in #63980). Requesting fast-track so we can turn the workflow on again before anything else breaks it. |
ShogunPanda
added
commit-queue
Member
Author
|
Landed in f1e01e7 |
Renegade334
removed
commit-queue
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Jul 1, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: nodejs#64222 Refs: nodejs#64040 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the latest libffi update, a macro is passing an
int *as along *in win32 builds, which makes clang unhappy.Refs: #64040