Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/internal/test_runner/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1839,6 +1839,11 @@ class Suite extends Test {
return { __proto__: null, ctx, args: [ctx] };
}

async filteredRun() {
await this.buildSuite;
return super.filteredRun();
}

async run() {
this.computeInheritedHooks();
const hookArgs = this.getRunArgs();
Expand Down
12 changes: 12 additions & 0 deletions test/fixtures/test-runner/awaited-filtered-suite.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import test from 'node:test';

await test.suite('Suite A', async () => {});

await test.suite('Suite B', async () => {
await test('Test 1', async () => {});
await test('Test 2', async () => {});
});

await test.suite('Suite C', async () => {
await test('Test 3', async () => {});
});
22 changes: 22 additions & 0 deletions test/parallel/test-runner-no-isolation-filtering.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
'use strict';
require('../common');
const fixtures = require('../common/fixtures');
Expand All @@ -7,6 +7,8 @@

const fixture1 = fixtures.path('test-runner', 'no-isolation', 'one.test.js');
const fixture2 = fixtures.path('test-runner', 'no-isolation', 'two.test.js');
const awaitedFilteredSuite =
fixtures.path('test-runner', 'awaited-filtered-suite.mjs');

test('works with --test-only', () => {
const args = [
Expand Down Expand Up @@ -71,6 +73,26 @@
assert.match(stdout, /# suites 0/);
});

test('awaited filtered suites do not leave cancelled tests', () => {
const args = [
'--test',
'--test-reporter=tap',
'--test-isolation=none',
'--test-name-pattern=C',
awaitedFilteredSuite,
];
const child = spawnSync(process.execPath, args);
const stdout = child.stdout.toString();

assert.strictEqual(child.status, 0);
assert.strictEqual(child.signal, null);
assert.match(stdout, /# tests 2/);
assert.match(stdout, /# suites 1/);
assert.match(stdout, /# pass 1/);
assert.match(stdout, /# fail 0/);
assert.match(stdout, /# cancelled 0/);
});

test('works with --test-skip-pattern', () => {
const args = [
'--test',
Expand Down
Loading