build: allow linting node.1#64157
Open
avivkeller wants to merge 6 commits into
Open
Conversation
nodejs-github-bot
added
build
aduh95
reviewed
Jun 27, 2026
Signed-off-by: avivkeller <me@aviv.sh>
aduh95
approved these changes
Jun 30, 2026
aduh95
requested changes
Jun 30, 2026
aduh95
left a comment
aduh95
left a comment
Contributor
There was a problem hiding this comment.
Wait, it looks like it needs internet access, which is a problem for integrators who run the tests in a sandbox, and also completely irrelevant for node.1:
UNDICI 59249: connecting to raw.githubusercontent.com using https:undefined
UNDICI 59249: connecting to raw.githubusercontent.com using https:undefined
UNDICI 59249: connection to raw.githubusercontent.com using https:undefined errored - No such binding: crypto
UNDICI 59249: connection to raw.githubusercontent.com using https:undefined errored - No such binding: crypto
UNDICI 59249: request to GET https://raw.githubusercontent.com/nodejs/node/HEAD/CHANGELOG.md errored - No such binding: crypto
UNDICI 59249: request to GET https://raw.githubusercontent.com//nodejs/node/HEAD/CHANGELOG.md errored - No such binding: crypto
[08:04:00.088] ERROR: fetch failedI got rid of it by commenting out the following in tools/doc/node_modules/@node-core/doc-kit/src/utils/configuration/index.mjs:
changelog: populate(CHANGELOG_URL, {
repository: 'nodejs/node',
ref: 'HEAD',
}),
Contributor
|
Another problem I've seen is that if I update $ make doc/node.1
make: 'doc/node.1' is up to date.Should we recommend |
Contributor
|
I was getting frustrated not understanding why me changing manually diff --git a/Makefile b/Makefile
index 963d0456fb0..e1f8bb5155e 100644
--- a/Makefile
+++ b/Makefile
@@ -935,2 +935,2 @@ out/doc/apilinks.json: $(wildcard lib/*.js) tools/doc/node_modules | out/doc
-.PHONY: doc/node.1
-doc/node.1: doc/api/cli.md tools/doc/node_modules
+.PHONY: node.1
+node.1: doc/api/cli.md tools/doc/node_modules
@@ -944 +944 @@ doc/node.1: doc/api/cli.md tools/doc/node_modules
- -o $(@D) \
+ -o doc \
@@ -1496 +1496 @@ tools/.mdlintstamp: tools/lint-md/node_modules/remark-parse/package.json $(LINT_
-tools/.manpagelintstamp: doc/api/cli.md tools/doc/node_modules
+tools/.manpagelintstamp: doc/api/cli.md tools/doc/node_modules doc/node.1
@@ -1508 +1508 @@ tools/.manpagelintstamp: doc/api/cli.md tools/doc/node_modules
- echo 'doc/node.1 is out of date; run `make doc/node.1` to regenerate it.'; \
+ echo 'doc/node.1 is out of date; run `make node.1` to regenerate it.'; \ |
Member
Author
|
Applied your patch! I'll update doc-kit to correctly output |
aduh95
approved these changes
Jul 1, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
avivkeller
added
commit-queue-squash
aduh95
reviewed
Jul 1, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Member
Author
|
Thanks for all your help, @aduh95! |
aduh95
approved these changes
Jul 2, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
make doc/node.1without triggering it on normal builds