Remove redundancy in node.config schema keys for test and watch#60943
Remove redundancy in node.config schema keys for test and watch#60943aakashamy777 wants to merge 2 commits intonodejs:mainfrom
Conversation
|
Review requested:
|
There was a problem hiding this comment.
This change removes the test and watch namespaces completely.
This is not what #60904 is about, it should only remove the test- prefix from keys.
The commit breaks many tests, run make test. Also it does not respect the commit guidelines, should be "lib: remove prefix from node.config.json namespaces" or something like that
Moreover I believe it should be an alias and not forbid the test- completely.
|
okay i will go through the issue and guidelines again, will update the codebase |
|
In addition of what Marco said, please add tests and PR description |
| } | ||
| } | ||
| }, | ||
| "test": { |
There was a problem hiding this comment.
I think we supposed to remove the prefix instead of the whole namespace no?
Remove redundant prefixes from keys in test and watch namespaces in the node.config JSON schema. Keys like test-concurrency and watch-path are now shown as concurrency and path within their respective namespaces, with the prefixed versions kept as aliases for backward compatibility. Refs: nodejs#60904
|
hey @marco-ippolito just refined the code... |
|
It doesnt look like it, the node.config.json is not updated |
4 participants
No description provided.