Dockerfile updates for sxa key - test only!#2554
Closed
MikeMcC399 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Build tests were successful in https://github.com/nodejs/docker-node/actions/runs/28732425343 Closing, unmerged as planned. cc: @sxa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
Background
As discussed in #2551, changing a key in keys/node.keys on its own does not test the change in CI.
It needs
./update.shto be run so that the Dockerfiles are updated and can be checked.Committing this change would however cause a change PR to be created which would propagate to https://github.com/docker-library/official-images if merged.
We don't have a strategy defined for handling such changes that shouldn't result in triggering new builds.
This PR is intended to be closed unmerged after CI tests successfully run.
Dockerfile changes with updated keys should be committed to the default branch automatically when a each individual release line is refreshed with a release.
Content
This PR runs
./update.shto refresh Dockerfiles for test purposes only.