Hyprland Visual Editor (HVE) - #462
Conversation
spiros132
left a comment
There was a problem hiding this comment.
Some feedback about the PR :)
|
Hi Spiros! I hope you're doing well. I’m reaching out to let you know that I’ve finished reviewing and applying all your feedback regarding the "Hyprland Visual Editor" code. I’ve performed a deep cleanup across all project files to ensure the plugin feels like a native part of Noctalia. These are the main changes: Translations (i18n): All language files have been reviewed, and missing lines have been added. Removal of Fallbacks: I’ve removed all || "" operators in translation calls (pluginApi?.tr()) across all modules, letting the Noctalia system handle keys on its own as per the official guidelines. No more Hardcoded Code: I’ve replaced all hardcoded values (hex colors, fixed margins, and font sizes) with the official Style and Color constants. I also swapped raw Qt types for N* widgets (like NBox, NText, etc.). Dynamic Scaling: All borders and critical dimensions now use Style.uiScaleRatio to ensure perfect rendering across all resolutions. I believe everything is now resolved and nothing has been missed. Thank you so much for the time you spent reviewing the plugin; your feedback has been incredibly helpful in understanding the Noctalia architecture. Looking forward to your thoughts! |
spiros132
left a comment
There was a problem hiding this comment.
Some more feedback about the PR, otherwise I think it looks good
Automatic Code Quality ReviewFile: hyprland-visual-editor/BarWidget.qmlFile: hyprland-visual-editor/Panel.qml
+ spacing: 0File: hyprland-visual-editor/Settings.qmlFile: hyprland-visual-editor/modules/AnimationModule.qmlFile: hyprland-visual-editor/modules/BorderModule.qmlFile: hyprland-visual-editor/modules/ShaderModule.qmlFile: hyprland-visual-editor/modules/WelcomeModule.qml |
|
"Thanks for catching those last details, Spiros! I've just replaced the hardcoded spacing: 0 and the border widths with the proper Style singletons. Regarding the .gitignore, I left it untouched for now pending your confirmation on my previous comment. I really appreciate your thorough review and your patience with this PR. I'm learning a lot about Noctalia's design standards thanks to your feedback! Let me know how you want to proceed." |
|
Hello, it looks great the only thing I could think of is that specific file that I can see called "git", if you can remove that one I think this plugin is ready. Thank you for the PR! :) |
|
"Hi Spiros! I've just removed the accidental 'git' file from the repository. If for some reason it still shows up on your end, please let me know and I'll investigate it more deeply. Thank you so much for your time and for all the help you've given me to get this plugin ready. Cheers!" |
Personal Note from the Author
Hello everyone! I wanted to add a sincere personal note. This is my very first time programming, and I realized a bit late how many mistakes I was making along the way. I want to deeply apologize if I wasted your valuable time. I absolutely love this wonderful project, and that admiration is what pushed me to try and contribute in some way.
I am opening this as a new PR because I accidentally closed my previous one. I completely messed up the synchronization of my fork and ended up breaking my repository! However, after getting serious, starting fresh, and following your developer guidelines strictly, I believe I finally have something decent and solid to offer. I leave it in your expert hands for review. Thank you for your immense patience!
Description
Initial release of the Hyprland Visual Editor (HVE) plugin.
This plugin acts as an aesthetic control center for Hyprland, allowing users to safely manage animations, window borders, and real-time screen shaders without permanently altering their main
hyprland.conf.Features included:
overlay.conffile, keeping the user's primary config safe and untouched.Checklist:
qs -c noctalia-shellWARNorERRORin the console log during runtime.