Skip to content

Fix incorrect header sizing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
b4rightnow wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Fix incorrect header sizing #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ext/binwrite/binary/pe/pe_sections.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ binwrite::rva_t::value_type binwrite::portable_executable_t::process_section_ali

void binwrite::portable_executable_t::update_section_headers()
{
const std::int64_t headers_size = std::min(static_cast<std::int64_t>(0x1000), static_cast<std::int64_t>(buffer_.size()));
const std::uint32_t size_of_headers = image()->nt_headers()->optional_header.size_of_headers;
const std::int64_t headers_size = std::min(static_cast<std::int64_t>(size_of_headers), static_cast<std::int64_t>(buffer_.size()));

std::vector headers_buffer(buffer_.begin(), buffer_.begin() + headers_size);

Expand Down