make-disk-image: Fix overriding kernel modules - #1277
Open
AlexLov wants to merge 2 commits into
Open
Conversation
After [#530764](NixOS/nixpkgs#530764) PR kernel modules should be passed as `kernelModules` instead of `kernel`. Fixes error: ``` … while evaluating definitions from `/nix/store/1c1jbpjisa2249vrffd97vmjdflbcprx-source/lib/make-disk-image.nix': (stack trace truncated; use '--show-trace' to show the full, detailed trace) error: vmTools: the `kernel` argument (kernel-modules) has no `target` attribute, so the kernel image filename cannot be determined. If you are passing a module tree (e.g. from `pkgs.aggregateModules`) to make extra modules available, pass it via `kernelModules` instead and keep `kernel` pointing at a real kernel derivation. Alternatively, pass `kernelImage` explicitly with the path of the bootable image relative to the `kernel` derivation output (e.g. "bzImage" or "Image"). ``` This should also fixes tests in [nix-community#1273](nix-community#1273) PR
Diffumist
suggested changes
Jul 9, 2026
Co-authored-by: Diffumist <git@diffumist.me>
Diffumist
approved these changes
Jul 10, 2026
JuneStepp
added a commit
to JuneStepp/disko
that referenced
this pull request
Jul 12, 2026
Contributor
|
After applying this patch the virtual machine hangs in stage-1 script (from initrd) at kernel module loading, on my machine. In my own scripts I see "loading kernel modules..." printed on the console. That text is not visible in the test output. I'm stuck on this, can't seem to figure out what is going wrong. Reproduction The commit hash is from nixos-unstable (2026-07-19) Logs from test make-disk-imageLogs from my own (similar) host configuration |
Could you provide the configuration or script that reproduces it? I can't reproduce this here. |
Contributor
|
My dev-stack is windows + hyper-v + nested virtualisation. Below the relevant log output, it explicitly mentions falling back to TCG backend instead of KVM. The command finished and produced a main.raw file successfully. |
kid
added a commit
to kid/home-ops
that referenced
this pull request
Aug 8, 2026
Adds modules/hosts/test-vm.nix, a throwaway host for smoke-testing the k3s/system-containerd/zfs-snapshotter wiring via `nix build .#nixosConfigurations.test-vm.config.system.build.vmWithDisko` without needing real hardware. Booting it surfaced two real bugs: - disko's lib/make-disk-image.nix passes an aggregated kernel-modules tree as vmTools' `kernel` arg, which broke against a nixpkgs vmTools API change (kernel/kernelModules split). Pin disko to nix-community/disko#1277 (unmerged fix) until it lands upstream. - k3s-containerd.nix's cni.bin_dir override was right, but dropping the transfer plugin's unpack_config as "redundant" wasn't: `ctr images pull --snapshotter zfs` failed with "no unpack platforms defined" without an explicit entry — the CRI snapshotter default doesn't extend to the transfer plugin's unpacker. Restored it. Also makes zfs-disk-single.nix's boot.zfs.* settings mkDefault (disko's vmVariantWithDisko needs to override devNodes/forceImportAll for qemu, where /dev/disk/by-id is empty) and re-states persist/cache neededForBoot under virtualisation.fileSystems, since vmWithDisko rebuilds fileSystems from scratch and doesn't inherit the host-level overrides. Verified live: booted test-vm, confirmed containerd.service active on the right socket, both local/containerd(/snapshotter) zfs datasets mount correctly, a zfs-snapshotter image pull succeeds, and k3s registers a Node object reporting containerd://2.3.1 as its runtime (NotReady is expected — no CNI in this isolated VM, Cilium ships via GitOps). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #530764 PR kernel modules should be passed as
kernelModulesinstead ofkernel.Fixes error:
This should also fixes tests in #1273 PR