Open
Conversation
Collaborator
Author
|
Btw who is responsible to Dispose the Stream? |
Member
|
Developer should take care of the stream they passed in. |
tonyqus
changed the title
Collaborator
Author
|
I just saw i had a variable still in the code, which i used temporary to check the result, I removed it. I also sealed the class and removed virtual form the context |
tonyqus
reviewed
Mar 17, 2026
tonyqus
reviewed
Mar 18, 2026
| /// </summary> | ||
| /// <param name="context">Contains the Path to the EPUB File or the Stream.</param> | ||
| /// <returns>Returns the <see cref="EpubBook"/> in <paramref name="context"/>.</returns> | ||
| public static EpubBook GetEpubBook(ParserContext context) |
Member
There was a problem hiding this comment.
Perhaps you can put the method in Utility if the EPubHelper only has one method
Collaborator
Author
There was a problem hiding this comment.
In my opinion there Utility is for more General things which are used more often (Validating Context, Get Stream, Checking if File is protected, ...)
To have a Method there which is used by 2 Parsers could be weird in my opinion.
If you want it there I can put it there
Is there anything else?
Otherwise I would merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added EPUBHelper, which gets the EPUB Book for the ParserContext. In addition the Context will also validated.
EPUBMetaParser & EPUBTextParser uses the new Method to get the EPUB Book
Changed the RootNamespace to Toxy since it will always use ToxyFramework for every new File