fix: include missing client/api modules in npm package#15
Open
reteps wants to merge 1 commit intonirholas:mainfrom
Open
fix: include missing client/api modules in npm package#15reteps wants to merge 1 commit intonirholas:mainfrom
reteps wants to merge 1 commit intonirholas:mainfrom
Conversation
search.js and parsers.js in src/client/api/ were missing from the published npm package, causing fatal errors on startup for users installing via npx xactions-mcp. Adds an explicit "files" field to package.json listing only the directories needed at runtime (src/, types/, api/config/). This fixes the missing module errors and reduces the package from 128 MB (3786 files) to 4 MB (306 files). Fixes nirholas#9 Fixes nirholas#11 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@reteps is attempting to deploy a commit to the kaivocmenirehtacgmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Prompt: |
reteps
commented
Apr 5, 2026
| "files": [ | ||
| "src/", | ||
| "types/", | ||
| "api/config/" |
Author
There was a problem hiding this comment.
Nothing else in api is needed for the server.
reteps
commented
Apr 5, 2026
| "algorithm-training", | ||
| "x-algorithm" | ||
| ], | ||
| "files": [ |
Author
There was a problem hiding this comment.
Without this, the resulting package was extremely bloated (100MB -> 4MB w/fix). Additionally, some of these files were added after publish.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"files"field topackage.jsonsosearch.jsandparsers.js(and all othersrc/client/api/modules) are included in the published npm packagesrc/,types/,api/config/)Fixes #9
Fixes #11
Test plan
npm pack --dry-runconfirmssrc/client/api/search.jsandsrc/client/api/parsers.jsare includednode -e "import('./src/client/Scraper.js')"resolves without errornode -e "import('./src/client/api/parsers.js')"resolves without errorvitest run— 871 passed, no new failures (3 pre-existing failures: MCP test uses node:test not vitest, x402 integration tests require running server)🤖 Generated with Claude Code