FIX: Propagate errors from run_without_submitting#3745
Merged
mgxd merged 4 commits intonipy:masterfrom Mar 2, 2026
Merged
Conversation
effigies
approved these changes
Mar 2, 2026
Member
effigies
left a comment
There was a problem hiding this comment.
Looks good. I can't readily think of something cleaner.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3745 +/- ##
==========================================
+ Coverage 72.88% 72.89% +0.01%
==========================================
Files 1279 1279
Lines 59351 59366 +15
==========================================
+ Hits 43256 43277 +21
+ Misses 16095 16089 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
829e791 to
7ba9f4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came up in nipreps/fmriprep#3611 , nipreps/nibabies#392
This adds a
_run_errorsattribute toDistributedPluginBasewhich is only utilized during therun()lifecycle, to ensure any encountered errors are properly reported.Each distributed plugin may need to be updated, this only touches on
MultiProcandLegacyMultiProc.