Skip to content

FIX: Propagate errors from run_without_submitting#3745

Merged
mgxd merged 4 commits intonipy:masterfrom
mgxd:fix/run-without-submitting-error
Mar 2, 2026
Merged

FIX: Propagate errors from run_without_submitting#3745
mgxd merged 4 commits intonipy:masterfrom
mgxd:fix/run-without-submitting-error

Conversation

@mgxd
Copy link
Member

@mgxd mgxd commented Mar 2, 2026

Came up in nipreps/fmriprep#3611 , nipreps/nibabies#392

This adds a _run_errors attribute to DistributedPluginBase which is only utilized during the run() lifecycle, to ensure any encountered errors are properly reported.

Each distributed plugin may need to be updated, this only touches on MultiProc and LegacyMultiProc.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can't readily think of something cleaner.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.89%. Comparing base (2b671ab) to head (7ba9f4a).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
nipype/pipeline/plugins/base.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3745      +/-   ##
==========================================
+ Coverage   72.88%   72.89%   +0.01%     
==========================================
  Files        1279     1279              
  Lines       59351    59366      +15     
==========================================
+ Hits        43256    43277      +21     
+ Misses      16095    16089       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies force-pushed the fix/run-without-submitting-error branch from 829e791 to 7ba9f4a Compare March 2, 2026 15:41
@mgxd mgxd merged commit 50a782a into nipy:master Mar 2, 2026
15 checks passed
@mgxd mgxd deleted the fix/run-without-submitting-error branch March 2, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants