feat: Add --fs-legacy-id flag#3606
Open
effigies wants to merge 3 commits intonipreps:maint/25.2.xfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maint/25.2.x #3606 +/- ##
================================================
- Coverage 73.27% 73.18% -0.09%
================================================
Files 60 60
Lines 4856 4866 +10
Branches 630 632 +2
================================================
+ Hits 3558 3561 +3
- Misses 1156 1162 +6
- Partials 142 143 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Are there other impacts on derivative reuse besides FS? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This adds a
--fs-legacy-idflag to disable adding_ses-<label>to FreeSurfer subject IDs. This can't be turned on by default for backwards compatibility reasons. Separately, we need to discuss what the best way forward is in general.I think this is related to #3581, but that appears not to be limited to FreeSurfer. Need to think more there, as well.