chore(deps-dev): bump @cloudflare/workers-types from 4.20260405.1 to 4.20260511.1#350
Open
dependabot[bot] wants to merge 22 commits into
Open
Conversation
… for issue ingest Drops the in-flight discipline files from this session into preseed/ so the work can be reviewed against codeflare's current versions and either merged wholesale or partially adopted. tdd-discipline.md is unchanged (already in sync). See accompanying issue for the full rationale and verification log. Net deltas (lines): spec-discipline 457 -> 804, documentation-discipline 339 -> 499.
…dd backlog re-triage Three rule additions to spec-discipline.md exposed by a live failure on ai-news-digest cycle-5 where the unleashed sweep stopped after clearing the current-cycle manifest while .review-needed.md still held 5 cycle-4 CQ-1 escalations that were now mechanically fixable. 1. CQ-1 split into Subclass A (name-only-match, AUTO-FIX rename in unleashed) and Subclass B (no-coverage, owner action). Previously both were "no auto-fix — authoring work"; that conflation produced a permanent backlog of mechanically-fixable findings. 2. CQ-1 skip clause for `Verification: Manual check` REQs. The literal-match auto-demote was spurious for REQs that declare manual verification by design (deploy workflows, runbook checklists, visual design-aesthetic checks). The agent now verifies a Notes doc-pointer instead. 3. New "Backlog re-triage" pass (18th manifest row, runs BEFORE other CQ checks). Walks every open .review-needed.md entry and re-classifies under current rules. Format header requirement on entries makes the pass deterministic without breaking older unstructured entries. The cycle-5 stop on ai-news-digest is the worked example cited inline in the new rule text.
- spec-discipline.md (40k char cap met) consolidates AC + Splitting families into umbrella H2s; adds chain enforcement rule that forces granulate → cap → split in a single auto-fix pass; adds worked outcomes for REQ-PIPE-003, REQ-OPS-008, REQ-PIPE-008. - documentation-discipline.md adds declared doc-shape preamble marker, TOC content rule for non-API docs, index-table link rule, and decisions/ one-file-per-AD shape (supersedes single-file convention). - REQ rendering template now uses blank lines between trailing fields (Constraints / Priority / Dependencies / Verification / Status) so GitHub renders each on its own line instead of collapsing to one paragraph; trailing-fields-collapsed MEDIUM finding added. - Cross-reference linking rule explicit: CON-*, REQ-* IDs in the four fields MUST render as anchor links. - Regenerated agent-seed via npm run generate:agent-seed.
… findings Both discipline-file preambles now name explicit HIGH findings: - manifest-pending-at-finalize — manifest finalised with rows still marked pending means the agent didn't run those rules - manifest-bare-evidence-count — status rows lacking concrete counts (e.g. bare 'ran (0 findings)' instead of 'ran (68 REQs, 0 findings)') hide whether the work happened Restores explicit enforcement language from issue #333 that was lost during compaction; total +260 chars, both files still under 40k.
…deletion Removed mandates that didn't match actual user pain: - doc-shape preamble marker requirement (entire section deleted; Pass 6 now resolves expected shape by filename via per-lane format templates table) - decisions one-file-per-AD restructure (entire section deleted; ADRs stay in a single ledger with index-table anchor links to in-file sections) - Pass 7 binding glob api-reference*.md narrowed to api-reference.md only Expanded scope where the gap was real: - TOC content rule now forbids REQ/CON refs in Contents blocks of ANY documentation file (api-reference.md included) Deprecated REQ handling: tombstone shape replaced with outright deletion. Deprecated is no longer a valid Status; auto-fix detects existing entries, folds any uncovered AC clauses into the successor, deletes the source REQ, and records the deletion in sdd/changes.md.
spec-discipline.md: rewrite Granularity rule with 10 hard triggers (sentence count, word count, subject shift, multi-site phrases, tie-break appendages, multi-path contracts, transform+effect, verb conjunctions, test-name candidate count) replacing the prior fuzzy "one observable behaviour" heuristic. Add rationale-clause escape clause. Compact Cross-cutting / Concern-boundary / Splitting-by- sub-feature prose to stay under the 40000-char cap. documentation-discipline.md: add Pass 13 - Within-section semantic consistency, applying to every documentation/**.md file. Three deterministic triggers - duplicate field within section, hybrid shape within section, repeated paragraph across sibling sections - each with mechanical auto-fix. Extend Pass 7 scope from api-reference.md only to the entire api-reference*.md family; adds file-level shape uniformity and prose paragraph cap. Regenerated agent-seed.generated.ts.
Three new binding triggers added to documentation-discipline.md after api-reference-admin.md restructure failed to catch its own drift: 1. toc-out-of-position: TOC exists but is not the first ## heading after preamble. Auto-fix relocates. 2. response-rendering-mixed / request-rendering-mixed: endpoint sections in the same api-reference*.md file mixing inline value form with heading-plus-table form for Response or Request field. Auto-fix re-renders to majority shape; ties go to heading-plus-table. 3. endpoint-field-order-drift: bolded field labels within endpoint sections out of canonical order (Authentication, Origin check, Rate limit, Request, Response, Implements, Notes). Auto-fix re-orders verbatim, no content loss. Pass 7 manifest row updated to reference new sub-rules. File at 37945 chars, 2055 under the 40k cap.
Three semantic-review questions every docs diff must self-answer: 1. Did I weasel? Lexical seeds (appropriately, robust, may, typically, ...) without numerical/behavioural anchor are MEDIUM prose-weasel. 2. Did I claim what I cannot verify? Every code-behaviour claim needs a fenced block, src_globs path, REQ backlink, or external ref. HIGH prose-unverifiable. 3. Did I explain WHY? Non-obvious behavior without rationale is LOW prose-missing-why; escalates to documentation/.doc-coverage.md. Restructuring (mechanical re-render) does NOT exempt the diff from Pass 14 — every diff opens new opportunities for weasel sentences to enter. Triggers are seeds for judgment, not closed lists. Read with a brain, not grep. Pass 13 trigger-3 auto-fix prose, Pass 7 prose-leakage paragraph, Pass 12 cache note, and Pass 13 trigger-1 auto-fix bullets compacted to keep total file under the 40000-char cap.
The Pass 14 rule scoped to 'every diff hunk that adds or rewrites prose in documentation/**'. On a /sdd clean --all audit run, the unit of review is the existing corpus, not the diff. A round on ai-news-digest claimed 'ran (8 doc files)' while inspecting 2 diff hunks — same dishonest-evidence-count shape spec-discipline's bare 'ran (0 findings)' rule was written to prevent. New scope paragraph: Pass 14 fires on every prose diff (mechanical re-render counts too); on /sdd clean --all or any audit run with no defining diff, scope widens to every paragraph in every canonical lane file. Dishonest-count callout codified. Existing 'restructuring is not exempt' clause folded into the scope paragraph; 'triggers are seeds for judgment' paragraph compacted to fit under the 40000-char cap. Final file size 39954, 46 under.
Splits the always-loaded ~40k-char spec-discipline.md and documentation-discipline.md rules into 7 conditional skills: - spec-enforce (spine, 18-row manifest, invokes details) - spec-enforce-ac (AC granularity + splitting) - spec-enforce-truth (CQ-1/2/3 truth checks) - doc-enforce (spine, 14-row manifest, invokes details) - doc-enforce-lanes (lane violations, dual-narrative ADRs) - doc-enforce-shape (per-lane templates, Pass 5/6/7) - doc-enforce-truth (Pass 8-12, cold-read) Reduces per-turn token load on spec-reviewer/doc-updater by ~80% when diff is small; full coverage preserved when scope=all. Manifest updated to ship the skills to .claude/.codex/.gemini/.config/opencode.
…nforcement skills spec-discipline.md: 40k -> 7.5k chars (-81%). documentation-discipline.md: 40k -> 6.3k chars (-84%). Each rule now retains identity, lane separation, status vocabulary, severity classification, modes, working-tree safety, and pointers to the spec-enforce*/doc-enforce* skill family. Detection algorithms, manifest execution, splitting mechanics, format templates, and truth-check passes live in the skills, invoked conditionally by spec-reviewer and doc-updater based on diff content.
…ement skills Both agents now invoke their respective spine skill (spec-enforce / doc-enforce) as a binding first action on every PR-boundary trigger and /sdd clean. The spine runs the full manifest inline and conditionally invokes detail skills based on diff content. Inline manifest detail removed from agent prose; phases 0 (triage), 1 (sync), 3 (apply), 4 (changelog), 5 (report) preserved unchanged. Skipping skill invocation is itself a HIGH manifest finding.
Wrote 218 documents (87 Claude + 131 non-Claude), up from 190. 28 new entries = 7 skills x 4 agent variants (Claude/Codex/Gemini/OpenCode).
tdd-discipline.md: 14.7k -> ~3k chars (-80%). Retains the one-question gut-check, severity classification, enforce_tdd lever, no-per-test-opt-out policy, skill pointer. tdd-enforce skill (~11k): 8-antipattern catalogue with BAD/GOOD examples (text-matching theater, tautology, mock-only, bare call-counts, empty body, silent skip, trivial assertion, name-lies), positive patterns (run the real thing, fixture-driven, contract not implementation, one bug-class per test), severity application table, enforce_tdd interaction, migration policy. code-reviewer agent: Test Quality section trimmed to a skill-invocation pointer; skipping tdd-enforce invocation when test files are in diff is itself a HIGH finding tdd-enforce-skill-not-invoked.
…ls into umbrella core rule + 4 skills Consolidates the commit -> push -> CI -> PR chain under a single umbrella core rule (rules/common/git-workflow.md, ~3.5k, default+advanced) with four branched skills: - ci-monitoring (default+advanced): single-bounded-iteration polling pattern, per-iteration decision matrix, stale-run cancellation - git-review-pipeline (advanced): SDD-mode review pipeline, PR-boundary trigger table, execution order, branch-protection setup - pr-workflow (default+advanced): PR creation template, body heredoc - deploy-credentials (default+advanced): GH_TOKEN + CF token env-var reference, check-then-fallback, secret-handling rules Deletes the standalone rules/ci-monitoring.md and rules/deploy-credentials.md (subsumed by the umbrella core + skill family). Total reduction in always-loaded core context: ~11k chars on every turn for every agent in default+advanced modes. Same coverage; skills invoked conditionally per use case (CI poll after push, PR creation on PR open, credential reference when needing gh/wrangler access).
Manifest: add 5 new skill entries (tdd-enforce advanced; ci-monitoring, pr-workflow, deploy-credentials default+advanced; git-review-pipeline advanced), widen rules/common/git-workflow.md to default+advanced (was advanced-only), remove rules/ci-monitoring.md + rules/deploy-credentials.md. agent-seed: 218 -> 236 documents (90 Claude + 146 non-Claude).
…d-only invariant The ECC contract (rules/common/, rules/typescript/, etc.) requires those files be advanced-only. Previous commit widened common/git-workflow.md to default+advanced (preserving ci-monitoring + deploy-credentials standard- mode coverage from the rules they replaced), which broke agent-seed-ecc-rules.test.ts. Fix: move the file from rules/common/git-workflow.md to top-level rules/git-workflow.md (alongside cloudflare-environment.md and no-local-builds.md where default+advanced is the established convention). Update manifest key and ECC test's expected common count (3 -> 2).
git-workflow.md left rules/common/ in the previous commit, so the total ECC rule count drops by 1.
…agents After the enforcement-skill split, doc-enforce and tdd-enforce default-bind to PR-boundary diff triggers. /review runs agents in a non-diff context (full-codebase static analysis), so the binding rules don't fire and the manifests stay dormant. Add an explicit directive to the Phase 2 agent prompt template: - doc-updater: invoke doc-enforce with scope=all on documentation/ - tdd-guide: invoke tdd-enforce with scope=all on every test file - code-reviewer: invoke tdd-enforce with scope=all when scope includes tests Restores full manifest coverage to /review cycles.
/review now requires an explicit scope flag, matching the /sdd clean
convention. Invoking /review alone prints a CLI usage screen modeled
after /sdd's help block.
Modes:
- /review --all reviews the entire codebase (Phase 2 scope=all)
- /review --diff reviews the current branch's diff against the PR base
(resolved via gh pr view --json baseRefName, fallback
origin/main); Phase 2 scope=diff
- --verify-high unchanged, combines with either scope
Phase 1 now parses arguments and records SCOPE / VERIFY_HIGH / SCOPE_HINT /
BASE_REF / DIFF_CMD into $REVIEW_DIR/.scope.txt so Task agents can read
the scope decision without re-parsing $ARGUMENTS.
Phase 2 agent prompt template parameterized: scope hardcoded to 'all' in
the prior commit is now substituted from .scope.txt. doc-enforce and
tdd-enforce skill invocations receive scope=$SCOPE so the same /review
pipeline drives both whole-codebase and diff-only modes.
…split skip review - Skills: 27 → 39 manifest entries (24 SKILL.md files); list new spec-enforce/doc-enforce/tdd-enforce family + git-workflow skills. - Rules: 27 → 25 (ci-monitoring + deploy-credentials moved to skills; git-workflow.md is now the umbrella core rule). - Manifest total: 77 → 90 entries. - AGENTS_SEEDED_CONFIGS: 187 → 236 documents (CC 90, Codex 40, Gemini 48, Copilot 10, OpenCode 48). - Per-mode seeds: default 25 → 36, advanced 184 → 232. - Plugins: 10 → 13 (context-mode plugin entries added). - Session Modes table updated to reflect rule/skill reshuffle. - /review --all/--diff mandatory scope flags + help screen noted.
Bumps [@cloudflare/workers-types](https://github.com/cloudflare/workerd) from 4.20260405.1 to 4.20260511.1. - [Release notes](https://github.com/cloudflare/workerd/releases) - [Changelog](https://github.com/cloudflare/workerd/blob/main/RELEASE.md) - [Commits](https://github.com/cloudflare/workerd/commits) --- updated-dependencies: - dependency-name: "@cloudflare/workers-types" dependency-version: 4.20260511.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
5 tasks
nikolanovoselec
force-pushed
the
develop
branch
2 times, most recently
from
81cf402 to
20e9da4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @cloudflare/workers-types from 4.20260405.1 to 4.20260511.1.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)