Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Sources/ParsingHelpers.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1172,10 +1172,20 @@ extension Formatter {
}
fallthrough
case .keyword("try"), .keyword("await"):
guard let prevToken = last(.nonSpaceOrCommentOrLinebreak, before: i) else {
guard let prevIndex = index(of: .nonSpaceOrCommentOrLinebreak, before: i) else {
return true
}
let prevToken = tokens[prevIndex]
switch prevToken {
case .operator("?", .postfix)
where [.keyword("try"), .keyword("as")].contains(
last(.nonSpaceOrCommentOrLinebreak, before: prevIndex) ?? .space("")
),
.operator("!", .postfix)
where [.keyword("try"), .keyword("as")].contains(
last(.nonSpaceOrCommentOrLinebreak, before: prevIndex) ?? .space("")
):
return false
case .number, .operator(_, .postfix), .endOfScope, .identifier,
.startOfScope("{"), .startOfScope(":"), .delimiter(";"),
.keyword("in") where lastSignificantKeyword(at: i) != "for",
Expand Down
60 changes: 60 additions & 0 deletions Tests/Rules/UnusedArgumentsTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1821,4 +1821,64 @@ final class UnusedArgumentsTests: XCTestCase {
"""
testFormatting(for: input, rule: .unusedArguments)
}

func testForLoopVariableUsedInGuardLetWithTryAwait() {
let input = """
for item in items {
guard let item = try? await storage.record(
matching: item.id
) else {
return
}

storage.save(item)
}
"""
testFormatting(for: input, rule: .unusedArguments)
}

func testForLoopVariableUsedInGuardLetWithTryForceAwait() {
let input = """
for item in items {
guard let item = try! await storage.record(
matching: item.id
) else {
return
}

storage.save(item)
}
"""
testFormatting(for: input, rule: .unusedArguments)
}

func testForLoopVariableUsedInGuardLetWithTryOptional() {
let input = """
for item in items {
guard let item = try? storage.record(
matching: item.id
) else {
return
}

storage.save(item)
}
"""
testFormatting(for: input, rule: .unusedArguments)
}

func testForLoopVariableUsedInGuardLetWithTryForce() {
let input = """
for item in items {
guard let item = try! storage.record(
matching: item.id
) else {
return
}

storage.save(item)
}
"""
testFormatting(for: input, rule: .unusedArguments)
}
}