Skip to content

Comments

fix: newline bug when building *_by_lua directives#86

Draft
Triple-Z wants to merge 1 commit intonginxinc:masterfrom
Triple-Z:fix-by-lua
Draft

fix: newline bug when building *_by_lua directives#86
Triple-Z wants to merge 1 commit intonginxinc:masterfrom
Triple-Z:fix-by-lua

Conversation

@Triple-Z
Copy link

@Triple-Z Triple-Z commented Jun 23, 2020

  • add an extra lua extension by_lua to solve this bug.

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

* add an extra lua extension to solve this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant