feat: add --web.nginx-metrics-only flag#1241
Open
jensschulze wants to merge 1 commit intonginx:mainfrom
Open
Conversation
* Skip exporting any non-NGINX metrics when `--web.nginx-metrics-only` is set.
|
Hi @jensschulze! Welcome to the project! 🎉 Thanks for opening this pull request! |
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a flag
---web.nginx-metrics-only. When the flag is set, export only Nginx metrics and skip all others.Motivation
We run this exporter (alongside others, also written in Go) in a Kubernetes environment using Kuma as the service mesh.
Metrics are aggregated per pod via Kuma sidecar's
metrics-hijackerfeature.When multiple containers within the same pod expose Go runtime metrics,
promhttpmetrics, etc., these metrics automatically receive the Kuma sidecar’s labels. As a result, Prometheus reports duplicated metrics. This issue occurs consistently in our setup. We identified two possible approaches:After evaluating these options, we decided to support disabling Go runtime metrics in the exporters.
Checklist