Update bamcmp - #9757
Merged
Merged
Conversation
mashehu
approved these changes
Jan 23, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
SPPearce
enabled auto-merge
January 23, 2026 10:25
Contributor
Author
|
Yeah, that was an autosuggestion that I just hit apply to... |
Contributor
Author
|
@nf-core-bot fix linting |
cavenel
pushed a commit
to cavenel/modules
that referenced
this pull request
Feb 5, 2026
* bamcmp to topic * Make bam files rather than misnamed sam files * Add samtools version * Update modules/nf-core/bamcmp/environment.yml Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com> * Fix linting and test * [automated] Fix linting with Prettier --------- Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com> Co-authored-by: nf-core-bot <core@nf-co.re>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swapping bamcmp to topic.
Also using samtools to actually make bam files, as the tool spits out sam files even if you name them bam files.