Skip to content

9649 new module mitorsaw #9739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eliottBo merged 32 commits into from
Jan 23, 2026
Merged

9649 new module mitorsaw #9739

eliottBo merged 32 commits into from
Jan 23, 2026
+1,342 −0

Conversation

@eliottBo
Copy link
Contributor

@eliottBo eliottBo commented Jan 22, 2026

PR checklist

Closes #9649

  • Add new module mitorsaw/haplotype for mitochondrial variant analysis
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker

@eliottBo eliottBo self-assigned this Jan 22, 2026
@eliottBo eliottBo added the new module Adding a new module label Jan 22, 2026
fellen31
fellen31 reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start!

fellen31
fellen31 approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@fellen31 fellen31 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Not sure what the failing CI check is about.

@ewels
Copy link
Member

ewels commented Jan 23, 2026

CI failure was in error sorry, tests should pass now..

@eliottBo eliottBo added this pull request to the merge queue Jan 23, 2026
Merged via the queue into nf-core:master with commit ae0ea82 Jan 23, 2026
35 checks passed
@eliottBo eliottBo deleted the 9649-new-module-mitorsaw branch January 23, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fellen31 fellen31 fellen31 approved these changes

Assignees

@eliottBo eliottBo

Labels

new module Adding a new module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new module: MITORSAW/haplotype

3 participants

@eliottBo @ewels @fellen31