Merge novel-allele-and-genotype branch to dev#458
Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
ssnn-airr
left a comment
There was a problem hiding this comment.
Other than the comment re the airr package version, LGTM
| "dplyr": "1.2.0", | ||
| "airr": "1.6.1", | ||
| "dplyr": "1.2.1", | ||
| "airr": "1.5.0", |
There was a problem hiding this comment.
This comment is just to double check that you want to downgrade the version of the airr package. Same change is present in other files as well.
There was a problem hiding this comment.
Thanks for spotting this. @Vivian0105 could you check whether it all still works with airr version 1.6.1 and if so update it in the container?
Added genotyping test of single sample and genotyping tutorials
ggabernet
left a comment
There was a problem hiding this comment.
I just have some minor comments and then this should be good to go once the final container with the EnchantR released version is available
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
ggabernet
left a comment
There was a problem hiding this comment.
Looks good to me, let's fix the failing tests and linting in the final PR (strict syntax)
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).