Skip to content

Merge novel-allele-and-genotype branch to dev#458

Merged
ggabernet merged 23 commits into
devfrom
novel-allele-and-genotype
May 13, 2026
Merged

Merge novel-allele-and-genotype branch to dev#458
ggabernet merged 23 commits into
devfrom
novel-allele-and-genotype

Conversation

@Vivian0105
Copy link
Copy Markdown
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/airrflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2fc2e97

+| ✅ 369 tests passed       |+
#| ❔   8 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗  27 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-04-28 17:15:37

Copy link
Copy Markdown
Contributor

@ssnn-airr ssnn-airr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment re the airr package version, LGTM

Comment thread tests/default.nf.test.snap Outdated
"dplyr": "1.2.0",
"airr": "1.6.1",
"dplyr": "1.2.1",
"airr": "1.5.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is just to double check that you want to downgrade the version of the airr package. Same change is present in other files as well.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. @Vivian0105 could you check whether it all still works with airr version 1.6.1 and if so update it in the container?

Comment thread docs/usage/genotyping_tutorial.md Outdated
Copy link
Copy Markdown
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have some minor comments and then this should be good to go once the final container with the EnchantR released version is available

Comment thread docs/usage.md Outdated
Comment thread docs/usage/genotyping_tutorial.md Outdated
Comment thread docs/usage/genotyping_tutorial.md
Comment thread docs/usage/genotyping_tutorial.md Outdated
Comment thread docs/usage/genotyping_tutorial.md Outdated
Comment thread nextflow_schema.json Outdated
Comment thread README.md Outdated
Vivian0105 and others added 8 commits May 11, 2026 14:10
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Copy link
Copy Markdown
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's fix the failing tests and linting in the final PR (strict syntax)

@ggabernet ggabernet merged commit 978a9c1 into dev May 13, 2026
11 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants