Honor COLUMNS when determining ANSI output width#7144
Open
Eldergenix wants to merge 1 commit into
Open
Conversation
Signed-off-by: Eldergenix <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6274
Summary
COLUMNSas the ANSI log width fallback whenTERMINAL_WIDTHis not set to a valid positive integer.TERMINAL_WIDTHoverride and existing terminal-width fallback behavior for absent or invalid values.COLUMNSbehavior in the environment variable reference.Validation
JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH ./gradlew :nextflow:test --tests nextflow.trace.AnsiLogObserverTest --no-daemon- passed after code changes; build successful in 5m 25s.JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH ./gradlew :nextflow:test --tests nextflow.trace.AnsiLogObserverTest --no-daemon- passed after the docs edit; Gradle reported tasks up-to-date and build successful in 13s.git diff --check- passed.Notes
ModuleNotFoundError: No module named 'sphinx').make test/ full CI matrix was not run locally.COLUMNS=50 nextflow run ...smoke was not run; the env-width fallback is covered byAnsiLogObserverTest.