Handle special keys only when IME is not compositing#3189
Merged
Conversation
This fixes interference between special keys (ESC, Enter, ...) for Chinese input methods and the UI. Closes nextcloud#2572 Signed-off-by: Chih-Hsuan Yen <645432-yan12125@users.noreply.gitlab.com>
yan12125
force-pushed
the
ime-key-handling
branch
from
480ef62 to
7e551d2
Compare
Member
|
Fine with me, though I cannot test whether it fixes the composition issue. |
raimund-schluessler
approved these changes
Jun 29, 2026
Signed-off-by: Raimund Schlüßler <raimund.schluessler+github@mailbox.org>
Refactor compositionstart and compositionend methods to remove event parameters. Signed-off-by: Raimund Schlüßler <raimund.schluessler+github@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes interference between special keys (ESC, Enter, ...) for Chinese input methods and the UI.
Closes #2572
I drafted this change long time ago (in 2024, roughly before submitting #2572). I don't remember exact reasons to change keyup to keydown. I just remember keyup doesn't work with compositing detection.
🤖 AI (if applicable)