Skip to content

fix(chunkedUploads): Ensure max parallel count is at least 1#59270

Merged
solracsf merged 3 commits intomasterfrom
ensureValueOneParallel
Mar 30, 2026
Merged

fix(chunkedUploads): Ensure max parallel count is at least 1#59270
solracsf merged 3 commits intomasterfrom
ensureValueOneParallel

Conversation

@solracsf
Copy link
Copy Markdown
Member

@solracsf solracsf commented Mar 27, 2026

Summary

If value is smaller than 1, return 1.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@solracsf solracsf added this to the Nextcloud 34 milestone Mar 27, 2026
@solracsf solracsf requested a review from a team as a code owner March 27, 2026 17:57
@solracsf solracsf added bug 3. to review Waiting for reviews labels Mar 27, 2026
@solracsf solracsf requested review from ArtificialOwl, CarlSchwan, leftybournes and salmart-dev and removed request for a team March 27, 2026 17:57
@solracsf solracsf enabled auto-merge March 27, 2026 17:57
@solracsf
Copy link
Copy Markdown
Member Author

/backport to stable33

@solracsf
Copy link
Copy Markdown
Member Author

/backport to stable32

@joshtrichards
Copy link
Copy Markdown
Member

No ceiling either. I wonder what happens at 9999? 🤔 Presumably the browser enforcement kicks in. So really it's a different matter than this one I suppose...

Copy link
Copy Markdown
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a quick unit test for the class while we're here. If it breaks something/gets in the way, feel free to remove it before merger.

@solracsf solracsf merged commit 04ee3af into master Mar 30, 2026
193 checks passed
@solracsf solracsf deleted the ensureValueOneParallel branch March 30, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Set files.chunked_upload.max_parallel_count to 0 crashes WebUI

3 participants