fix: allow renaming files with just update permissions

[icewind1991]

• resolves [Bug]: Unable to rename files in shared folders without delete permission #48983

Only moving to another folder needs the delete+create permissions, for moving in the same folder just update is enough.

TODO:

• Update files webui permissions check

[icewind1991]

/compile

[szaimen]

🐘

[icewind1991]

(I'll rebase etc once reviewed)

[mgallien]

tested with the desktop client and works fine

Addressed

[mgallien]

@icewind1991 will this change be backported to stable branches ?

[mgallien]

wrong test with only partial patch applied
I can confirm that this is working fine when applied on 30.0.11

[icewind1991]

/compile

[susnux]

Makes sense but would it not make more sense to directly expose the permission in the backend?

[susnux]

Would it not better to move the logic to the backend?

server/lib/public/Files/DavUtil.php

Line 36 in c826288

public static function getDavPermissions(FileInfo $info): string {

[icewind1991]

Added the proper rename logic to the dav permissions.

But the permissions on the js side there is the numeric permissions mask (instead of the string flags), which doesn't distinguish the permissions.

Solving this would need changes in @nextcloud/files I think

[icewind1991]

/compile

[icewind1991]

/backport to stable33

[icewind1991]

/backport to stable32

[saw-jan]

This breaks the existing usage of DavUtil::getDavPermissions(...) in other apps
Example in https://github.com/nextcloud/integration_openproject/blob/253c6d0d1b8ba4c8ea0bd965ba7442c2117efbfe/lib/Controller/FilesController.php#L293

App will work fine with NC 33.0.1, but after upgrade to future version NC 33.0.2 (includes this changes), app will fail.

{
  "ocs": {
    "meta": {
      "status":"failure",
      "statuscode":996,
      "message":"Internal Server Error\nToo few arguments to function OCP\\Files\\DavUtil::getDavPermissions(), 1 passed in \/var\/www\/html\/custom_apps\/integration_openproject\/lib\/Controller\/FilesController.php on line 293 and exactly 2 expected in file '\/var\/www\/html\/lib\/public\/Files\/DavUtil.php' line 37",
      "totalitems":"",
      "itemsperpage":""
    },
  "data":[]
  }
}

upgrading in patch level breaks the code.
Ref: #59241