Skip to content

Reorg edit Buttons#3244

Closed
chrissooo wants to merge 2 commits into
nextcloud:mainfrom
chrissooo:reorg-edit-buttons
Closed

Reorg edit Buttons#3244
chrissooo wants to merge 2 commits into
nextcloud:mainfrom
chrissooo:reorg-edit-buttons

Conversation

@chrissooo

@chrissooo chrissooo commented Jun 30, 2026

Copy link
Copy Markdown

This Pull Request reorganizes the action buttons (Edit, Direct Edit, and Preview) within the note editing flow. Previously, these buttons were managed individually within the fragments (NoteEditFragment, NotePreviewFragment, etc.). This change centralizes the button management into the EditNoteActivity.
Changes:

  • Centralization: The buttons for editing, previewing, and rich-text editing are now part of the EditNoteActivity layout.
  • Layout Upgrade: Updated activity_edit.xml to use a CoordinatorLayout for better control over Floating Action Button (FAB) behavior.
  • Dynamic Visibility: Buttons are shown or hidden dynamically based on the current mode (Preview vs. Editor) and server capabilities (Direct Editing support).
  • Scroll Behavior: FABs now respond to scroll events and hide/show accordingly using ExtendedFabUtil.
  • Menu Cleanup: Removed redundant menu items from the toolbar, as these actions are now prominently handled by the FABs.

🖼️ Videos

🏚️ Before

screen-20260630-163107-1782829835601.1.mp4

🏡 After

screen-20260630-163248-1782829939085.1.mp4

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Disclosure: I am an external contributor, and this change was developed with the assistance of AI.
Assisted-by: Claude Code 2.1.80 (Claude Sonnet 3.7)

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 13 complexity · 0 duplication

Metric Results
Complexity 13
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant