Skip to content

feat: read calendar ACL properly#7951

Merged
SebastianKrupinski merged 2 commits intomainfrom
feat/calendar-federation-readwrite
Feb 13, 2026
Merged

feat: read calendar ACL properly#7951
SebastianKrupinski merged 2 commits intomainfrom
feat/calendar-federation-readwrite

Conversation

@SebastianKrupinski
Copy link
Contributor

Summary

  • modified ACL's for calendar federation

@SebastianKrupinski SebastianKrupinski self-assigned this Feb 3, 2026
@SebastianKrupinski SebastianKrupinski added the 2. developing Work in progress label Feb 3, 2026
Comment on lines +95 to +97
const canCreateObject = calendar.currentUserPrivilegeSet.includes('{DAV:}bind') || calendar.currentUserPrivilegeSet.includes('{DAV:}write') || calendar.currentUserPrivilegeSet.includes('{DAV:}all') === true
const canModifyObject = calendar.currentUserPrivilegeSet.includes('{DAV:}write-content') || calendar.currentUserPrivilegeSet.includes('{DAV:}write') || calendar.currentUserPrivilegeSet.includes('{DAV:}all') === true
const canDeleteObject = calendar.currentUserPrivilegeSet.includes('{DAV:}unbind') || calendar.currentUserPrivilegeSet.includes('{DAV:}write') || calendar.currentUserPrivilegeSet.includes('{DAV:}all') === true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth it to add these in cdav library instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Yes that makes sense! I will do that, but at the moment this is so we can get a feature out... Then I will modify the dav-library

@SebastianKrupinski SebastianKrupinski added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 10, 2026
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Feb 10, 2026
@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review February 10, 2026 14:31
@SebastianKrupinski SebastianKrupinski force-pushed the feat/calendar-federation-readwrite branch 2 times, most recently from 2c3a825 to 1dc842c Compare February 10, 2026 21:11
@SebastianKrupinski SebastianKrupinski force-pushed the feat/calendar-federation-readwrite branch from 1dc842c to 35be294 Compare February 13, 2026 16:41
Signed-off-by: SebastianKrupinski <[email protected]>
@SebastianKrupinski SebastianKrupinski force-pushed the feat/calendar-federation-readwrite branch from 35be294 to ea4d703 Compare February 13, 2026 17:06
Signed-off-by: SebastianKrupinski <[email protected]>
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/mixins/EditorMixin.js 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@SebastianKrupinski SebastianKrupinski merged commit 4a145db into main Feb 13, 2026
45 of 47 checks passed
@SebastianKrupinski SebastianKrupinski deleted the feat/calendar-federation-readwrite branch February 13, 2026 18:07
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

3 participants